cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 1 Releases 163 Wiki Activity

contact and group retry logic update and connection awareness #276

Manually merged
sarah merged 1 commits from dan/cwtch:reconncect into master 2019-09-28 03:43:09 +00:00
Conversation 5 Commits 1 Files Changed 9 +97 -64
dan commented 2019-09-26 23:45:36 +00:00
Owner
Copy Link
  • make contact retry plugin acn connection state aware
  • make contact retry plugin do groups
  • remove connectionManager bad retry logic
  • allow queringing of ACN status
- make contact retry plugin acn connection state aware - make contact retry plugin do groups - remove connectionManager bad retry logic - allow queringing of ACN status
sarah was assigned by dan 2019-09-26 23:45:36 +00:00
buildbot commented 2019-09-26 23:51:39 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/637

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/637
buildbot commented 2019-09-26 23:51:40 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/638

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/638
sarah reviewed 2019-09-26 23:56:24 +00:00
app/plugins/contactRetry.go Outdated
@ -14,0 +13,4 @@
type contactType int
const (
peerType contactType = iota
sarah commented 2019-09-26 23:55:53 +00:00
Owner
Copy Link

Is is a peer type or a contact type (I prefer peer, contact has specific semantics that'd like to avoid)

Is is a peer type or a contact type (I prefer peer, contact has specific semantics that'd like to avoid)
dan commented 2019-09-27 00:55:15 +00:00
Author
Owner
Copy Link

what do we call what is both groups and peers?

what do we call what is both groups and peers?
dan commented 2019-09-27 22:30:04 +00:00
Author
Owner
Copy Link

change to connectionType and peerConn and groupConn

change to connectionType and peerConn and groupConn
app/plugins/contactRetry.go Outdated
@ -25,3 +34,3 @@
breakChan chan bool
peers sync.Map //[string]*peer
peers sync.Map //[string]*contact
sarah commented 2019-09-26 23:56:10 +00:00
Owner
Copy Link

peers or contacts?

peers or contacts?
dan commented 2019-09-27 00:55:57 +00:00
Author
Owner
Copy Link

yeah the var should be called 'contacts' or? (as it has peers and groups)

yeah the var should be called 'contacts' or? (as it has peers and groups)
dan commented 2019-09-27 22:31:03 +00:00
Author
Owner
Copy Link

Updated.
Also the previous group retry code was very bad (one uniform timeout for all conns!?! and no connection awareness.) while moving forward separate managers may be wanted, for now this is a huge improvement

Updated. Also the previous group retry code was very bad (one uniform timeout for all conns!?! and no connection awareness.) while moving forward separate managers may be wanted, for now this is a huge improvement
buildbot commented 2019-09-27 22:35:27 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/639

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/639
buildbot commented 2019-09-27 22:35:40 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/640

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/640
sarah closed this pull request 2019-09-28 03:43:09 +00:00
sarah closed this pull request 2019-09-28 03:43:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
sarah
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#276
No description provided.
Delete Branch "dan/cwtch:reconncect"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?