cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

add get/set attribute for profile/contact/group to cwtch_peer that does the action and emits an event #279

Manually merged
sarah merged 1 commits from dan/cwtch:getsetattr into master 2019-10-31 21:48:46 +00:00
Conversation 2 Commits 1 Files Changed 6 +79 -18
dan commented 2019-10-31 21:42:12 +00:00
Owner
Copy Link

a bunch of code in ui was calling in pattern:

the.Peer.Profile.GetContact(id).SetAttribute(...)
the.bus.Publish( {... SetAttribute ....} )

And I was looking at adding more

Adding these function to the cwtch_peer make it a more useful interface for UIs to build on

There is a big PR for ui coming with a bunch of red from this :)

Also

  • rename profile.GetGroupByGroupID to GetGroup for consistency
a bunch of code in ui was calling in pattern: ``` the.Peer.Profile.GetContact(id).SetAttribute(...) the.bus.Publish( {... SetAttribute ....} ) ``` And I was looking at adding more Adding these function to the cwtch_peer make it a more useful interface for UIs to build on There is a big PR for ui coming with a bunch of red from this :) Also - rename profile.GetGroupByGroupID to GetGroup for consistency
sarah was assigned by dan 2019-10-31 21:42:12 +00:00
buildbot commented 2019-10-31 21:48:11 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/649

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/649
buildbot commented 2019-10-31 21:48:26 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/650

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/650
sarah closed this pull request 2019-10-31 21:48:46 +00:00
sarah closed this pull request 2019-10-31 21:48:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
sarah
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#279
No description provided.
Delete Branch "dan/cwtch:getsetattr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?