cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

creating a new v1 storage system with shared salt and only key in memory #297

Manually merged
sarah merged 1 commits from dan/cwtch:pwv1 into master 2020-01-21 20:06:15 +00:00
Conversation 5 Commits 1 Files Changed 20 +1205 -450
dan commented 2020-01-15 00:08:02 +00:00
Owner
Copy Link

followed design doc

  • new v1 system stores a SALT file, derives and stores in memory key only, not password
  • cut some parts out of v0 as they weren't needed, its just for upgrade and testing
  • upgrade v0 to v1 code
  • minimal updates to the app to use the new system
followed design doc - new v1 system stores a SALT file, derives and stores in memory key only, not password - cut some parts out of v0 as they weren't needed, its just for upgrade and testing - upgrade v0 to v1 code - minimal updates to the app to use the new system
sarah was assigned by dan 2020-01-15 00:08:02 +00:00
buildbot commented 2020-01-15 00:14:47 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/723

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/723
buildbot commented 2020-01-15 00:15:21 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/722

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/722
dan commented 2020-01-15 00:26:59 +00:00
Author
Owner
Copy Link

added a fix to server/metrics test to make it deterministic and not sleep based cus
https://build.openprivacy.ca/cwtch.im/cwtch/723
random fail

added a fix to server/metrics test to make it deterministic and not sleep based cus https://build.openprivacy.ca/cwtch.im/cwtch/723 random fail
buildbot commented 2020-01-15 00:31:23 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/724

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/724
sarah approved these changes 2020-01-15 17:39:54 +00:00
sarah left a comment
Owner
Copy Link

lgtm

lgtm
storage/profile_store_test.go Outdated
@ -93,2 +45,2 @@
eventBus.Publish(event.NewEvent(event.NewGroupInvite, map[event.Field]string{event.TimestampReceived: time.Now().Format(time.RFC3339Nano), event.RemotePeer: ps1.GetProfileCopy(true).Onion, event.GroupInvite: string(invite)}))
time.Sleep(1 * time.Second)
ps1.AddGroup(invite, profile.Onion)
//time.Sleep(1 * time.Second)
sarah commented 2020-01-15 17:36:07 +00:00
Owner
Copy Link

delete

delete
storage/profile_store_test.go Outdated
@ -128,2 +52,3 @@
}
time.Sleep(3 * time.Second)
// TODO: Proper wait till done
//time.Sleep(3 * time.Second)
sarah commented 2020-01-15 17:36:26 +00:00
Owner
Copy Link

delete

delete
buildbot commented 2020-01-21 19:40:26 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/725

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/725
sarah closed this pull request 2020-01-21 20:06:15 +00:00
sarah closed this pull request 2020-01-21 20:06:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
sarah
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#297
No description provided.
Delete Branch "dan/cwtch:pwv1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?