Allow Peers to Store History #316

sarah · 2020-07-08T18:30:53Z

sarah 评论于

2020-07-08 18:30:53 +00:00

管理员

没有提供说明。

dan 于 2020-07-08 18:30:53 +00:00 被 sarah 指派

buildbot 评论于

2020-07-08 18:38:18 +00:00

普通成员

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/769

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/769

buildbot 评论于

2020-07-08 19:41:31 +00:00

普通成员

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/771

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/771

dan 请求变更 2020-07-08 19:52:58 +00:00

storage/v1/profile_store.go 已过期

					
				@ -258,6 +260,10 @@ func (ps *ProfileStoreV1) load() error {

									contact.Authorization = model.AuthApproved

								}

							}

dan 评论于

2020-07-08 19:45:59 +00:00

管理员

like above, prolly better to check at load if the attribute is set or not and set it accordingly instead of the double initializer for it you have in the event handler below. Also since this is a required attribute, should also be added to cwtchPeer.AddContact, line 194 has the attributes being initialized.

then we can create a stream store only where needed, then the event handler can just reach for the stream store and if there is one, use it, if not, not use it, simplifying that code a bunch in the event handler

BUT it does mean then doing processing of the SavePeerHistory event and creating or deleting stream stores there.
but that's actually good as right now we don't capture that, so we never delete history when its changed? which means when someone turns it off, the existing history sits there, forever being loaded, but never updated, which isn't great, so that event does need handling regardless

also prolly want a ps.save after the loop to capture and save any new defaults added

like above, prolly better to check at load if the attribute is set or not and set it accordingly instead of the double initializer for it you have in the event handler below. Also since this is a required attribute, should also be added to cwtchPeer.AddContact, line 194 has the attributes being initialized. then we can create a stream store only where needed, then the event handler can just reach for the stream store and if there is one, use it, if not, not use it, simplifying that code a bunch in the event handler BUT it does mean then doing processing of the SavePeerHistory event and creating or deleting stream stores there. but that's actually good as right now we don't capture that, so we never delete history when its changed? which means when someone turns it off, the existing history sits there, forever being loaded, but never updated, which isn't great, so that event does need handling regardless also prolly want a ps.save after the loop to capture and save any new defaults added

storage/v1/profile_store.go 已过期

					
				@ -346,0 +368,4 @@

												ss.Write(message)

											}

										}

									case event.DontSaveHistoryDefault:

dan 评论于

2020-07-08 19:46:29 +00:00

管理员

very rust of you? :P
but we can just have hte one empty default

very rust of you? :P but we can just have hte one empty default

storage/v1/profile_store.go 已过期

					
				@ -346,0 +376,4 @@

										}

									}

								}

								ps.save()

dan 评论于

2020-07-08 19:48:03 +00:00

管理员

shouldn't need this if we aren't setting a default here

storage/v1/profile_store.go 已过期

					
				@ -346,0 +382,4 @@

							}

						case event.NewMessageFromPeer:

							contact, exists := ps.profile.GetContact(ev.Data[event.RemotePeer])

							if exists {