Initial Prototype of Event Hooks #488

Merged
sarah merged 13 commits from eventhooks into master 2023-02-28 18:59:50 +00:00
Owner

This PR provide a working sketch of the cwtch stable event hook system.

Currently Implemented:

  • All get/rel val code handled by extenion modules
  • All filesharing code moved into File Sharing Functionality
  • Registering custom events works

To do:

  • Experiment handling not yet moved into Application from libcwtch-go

Current actions requires: Initial review / comments / thoughts.

This PR provide a working sketch of the cwtch stable event hook system. Currently Implemented: - All get/rel val code handled by extenion modules - All filesharing code moved into File Sharing Functionality - Registering custom events works To do: - Experiment handling not yet moved into Application from libcwtch-go Current actions requires: Initial review / comments / thoughts.
dan was assigned by sarah 2023-01-05 21:53:47 +00:00
sarah added 2 commits 2023-01-05 21:53:48 +00:00
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/106
dan requested changes 2023-01-17 21:28:49 +00:00
peer/hooks.go Outdated
@ -0,0 +9,4 @@
type ProfileHooks interface {
// RegisterEvents returns a set of events that the extension is interested hooking
RegisterEvents() []event.Type
Owner

EventsToRegister()

EventsToRegister()
sarah marked this conversation as resolved
peer/hooks.go Outdated
@ -0,0 +12,4 @@
RegisterEvents() []event.Type
// RegisterExperiments RegisterExperiments returns a set of experiments that the extension is interested in being notified about
RegisterExperiments() []string
Owner

ExperimentsToRegister

ExperimentsToRegister
sarah marked this conversation as resolved
sarah added 1 commit 2023-01-25 20:32:49 +00:00
sarah added 1 commit 2023-01-25 20:35:05 +00:00
continuous-integration/drone/pr Build is passing Details
84c8c8bc11
Rename API
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/108
dan requested changes 2023-01-31 21:23:52 +00:00
app/app.go Outdated
@ -69,0 +77,4 @@
// many other parts of Cwtch are likely to fail also.
settings, err := InitGlobalSettingsFile(appDirectory, DefactoPasswordForUnencryptedProfiles)
if err != nil {
log.Errorf("error initializing global settings file %. Global settings might not be loaded or saves", err)
Owner

s/saves/saved/ ?

should we return or exit tho?

s/saves/saved/ ? should we return or exit tho?
dan marked this conversation as resolved
sarah changed title from WIP: Initial Prototype of Event Hooks to Initial Prototype of Event Hooks 2023-02-28 18:09:49 +00:00
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/109
sarah force-pushed eventhooks from 71c0149f10 to d2fd57853a 2023-02-28 18:13:40 +00:00 Compare
sarah added 12 commits 2023-02-28 18:13:53 +00:00
dan approved these changes 2023-02-28 18:24:47 +00:00
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/111
sarah added 1 commit 2023-02-28 18:33:23 +00:00
continuous-integration/drone/pr Build is passing Details
243b827522
bool -> atomic.Bool to prevent "race condition"
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/112
sarah merged commit 456afb0262 into master 2023-02-28 18:59:50 +00:00
Sign in to join this conversation.
No description provided.