Support Profile Status and Profile Attributes. Auto Fetch Updates on a Heartbeat. Move Profile Image Download Checks to Cwtch #503

Merged
sarah merged 4 commits from autodownload into master 2023-04-04 21:04:02 +00:00
Owner
No description provided.
dan was assigned by sarah 2023-04-03 19:46:10 +00:00
sarah added 1 commit 2023-04-03 19:46:11 +00:00
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/127
dan reviewed 2023-04-03 21:20:15 +00:00
@ -31,0 +47,4 @@
// if we have re-authenticated with thie peer then request their profile image...
if connections.ConnectionStateToType()[ev.Data[event.ConnectionState]] == connections.AUTHENTICATED {
// Request some profile information...
profile.SendScopedZonedGetValToContact(ci.ID, attr.PublicScope, attr.ProfileZone, constants.Name)
Owner

should be 1 fun reqinfo() so we dont dup this code and adding new is simple

should be 1 `fun reqinfo()` so we dont dup this code and adding new is simple
dan marked this conversation as resolved
@ -51,0 +54,4 @@
if err == nil {
// if we have re-authenticated with thie peer then request their profile image...
if connections.ConnectionStateToType()[ev.Data[event.ConnectionState]] == connections.AUTHENTICATED {
profile.SendScopedZonedGetValToContact(ci.ID, attr.PublicScope, attr.ProfileZone, constants.CustomProfileImageKey)
Owner

do we likewise want this on a heartbeat in case they change?

do we likewise want this on a heartbeat in case they change?
@ -60,1 +60,4 @@
const Archived = "archived"
const ProfileStatus = "profile-status"
const ProfileAttribute1 = "profile-attribute-1"
Owner

asking ux, not sure how i feel about attr 1-3

asking ux, not sure how i feel about attr 1-3
@ -1486,1 +1486,4 @@
}
// Safe Access to Extensions
cp.extensionLock.Lock()
Owner

this loop through extension for ones matching the event and dispatching is repeated a few times, should be pulled out into a function somewhere

this loop through extension for ones matching the event and dispatching is repeated a few times, should be pulled out into a function somewhere
@ -1487,0 +1495,4 @@
continue
}
if cp.checkEventExperiment(extension, ev.EventType) {
extension.extension.OnEvent(ev, cp)
Owner

we're doing onEvent form peer.handle event for onPeerStausChange, but did registering the onPeerEventStatusChange event event bus listener in the extension not mean it'd pull it off the bus? like i'm assuing it is doing for heartbeat? or else if not than we i assume need a dup of this for heartbeat? and to have peer consume it?

we're doing onEvent form peer.handle event for onPeerStausChange, but did registering the onPeerEventStatusChange event event bus listener in the extension not mean it'd pull it off the bus? like i'm assuing it is doing for heartbeat? or else if not than we i assume need a dup of this for heartbeat? and to have peer consume it?
dan marked this conversation as resolved
sarah added 1 commit 2023-04-03 21:33:42 +00:00
continuous-integration/drone/pr Build is failing Details
4d81529ce2
Update Profile Extension to remove Duplication
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/128
sarah added 1 commit 2023-04-03 21:49:55 +00:00
continuous-integration/drone/pr Build is failing Details
7107ad1eaa
Close Heartbeat Queue
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/129
sarah added 1 commit 2023-04-03 21:58:44 +00:00
continuous-integration/drone/pr Build is passing Details
51f85ea619
Fix queue shutdown
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/130
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/132
dan approved these changes 2023-04-04 20:53:40 +00:00
dan left a comment
Owner

approving. logic is good
provisional approval on 3 attribute line design for testing but want to review wiyh UX and tesers before full 1.12, so lets get it out

approving. logic is good provisional approval on 3 attribute line design for testing but want to review wiyh UX and tesers before full 1.12, so lets get it out
sarah merged commit 2e59cc43ab into master 2023-04-04 21:04:02 +00:00
Sign in to join this conversation.
No description provided.