Support Profile Status and Profile Attributes. Auto Fetch Updates on a Heartbeat. Move Profile Image Download Checks to Cwtch #503
No reviewers
Labels
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/cwtch#503
Loading…
Reference in New Issue
No description provided.
Delete Branch "autodownload"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch/127
@ -31,0 +47,4 @@
// if we have re-authenticated with thie peer then request their profile image...
if connections.ConnectionStateToType()[ev.Data[event.ConnectionState]] == connections.AUTHENTICATED {
// Request some profile information...
profile.SendScopedZonedGetValToContact(ci.ID, attr.PublicScope, attr.ProfileZone, constants.Name)
should be 1
fun reqinfo()
so we dont dup this code and adding new is simple@ -51,0 +54,4 @@
if err == nil {
// if we have re-authenticated with thie peer then request their profile image...
if connections.ConnectionStateToType()[ev.Data[event.ConnectionState]] == connections.AUTHENTICATED {
profile.SendScopedZonedGetValToContact(ci.ID, attr.PublicScope, attr.ProfileZone, constants.CustomProfileImageKey)
do we likewise want this on a heartbeat in case they change?
@ -60,1 +60,4 @@
const Archived = "archived"
const ProfileStatus = "profile-status"
const ProfileAttribute1 = "profile-attribute-1"
asking ux, not sure how i feel about attr 1-3
@ -1486,1 +1486,4 @@
}
// Safe Access to Extensions
cp.extensionLock.Lock()
this loop through extension for ones matching the event and dispatching is repeated a few times, should be pulled out into a function somewhere
@ -1487,0 +1495,4 @@
continue
}
if cp.checkEventExperiment(extension, ev.EventType) {
extension.extension.OnEvent(ev, cp)
we're doing onEvent form peer.handle event for onPeerStausChange, but did registering the onPeerEventStatusChange event event bus listener in the extension not mean it'd pull it off the bus? like i'm assuing it is doing for heartbeat? or else if not than we i assume need a dup of this for heartbeat? and to have peer consume it?
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch/128
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch/129
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch/130
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch/132
approving. logic is good
provisional approval on 3 attribute line design for testing but want to review wiyh UX and tesers before full 1.12, so lets get it out