cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

Enable a SendPeerMessage EngineHook for Fuzzbot #508

Merged
sarah merged 5 commits from fuzzbot into master 2023-04-20 21:00:15 +00:00
Conversation 3 Commits 5 Files Changed 11 +57 -16
sarah commented 2023-04-20 19:20:33 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2023-04-20 19:20:33 +00:00
buildbot commented 2023-04-20 19:32:29 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/146

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/146
dan requested changes 2023-04-20 20:27:45 +00:00
dan left a comment
Owner
Copy Link

I don't love that this debuging only new feature's been added to our public main API NewApp

Any change engine can instantiate with the DefaultEngineHooks and we just add a new App API to installEngineHook that fuzzbot can use?

I don't love that this debuging only new feature's been added to our public main API NewApp Any change engine can instantiate with the DefaultEngineHooks and we just add a new App API to `installEngineHook` that fuzzbot can use?
protocol/connections/engine.go Outdated
@ -85,13 +86,21 @@ type Engine interface {
Shutdown()
}
type EngineHooks interface {
dan commented 2023-04-20 20:25:22 +00:00
Owner
Copy Link

why is this type not in enginehook.go?

why is this type not in enginehook.go?
dan commented 2023-04-20 20:30:54 +00:00
Owner
Copy Link

... or I guess can't app instantiate with DefaultEngineHooks either, that might make more sense, other wise install would fial if there wasnt an engine yet

... or I guess can't app instantiate with DefaultEngineHooks either, that might make more sense, other wise install would fial if there wasnt an engine yet
sarah force-pushed fuzzbot from 5fadb48e33 to 7255a6c71e 2023-04-20 20:34:07 +00:00 Compare
sarah added 1 commit 2023-04-20 20:36:52 +00:00
continuous-integration/drone/pr Build was killed Details
93c9813d96 Move EngineHooks into Protocol
sarah added 1 commit 2023-04-20 20:38:31 +00:00
continuous-integration/drone/pr Build is pending Details
746bfffb7c EngineHooks into enginehooks.go
sarah added 1 commit 2023-04-20 20:39:03 +00:00
continuous-integration/drone/pr Build is passing Details
210c91f7f7 Mutex enginehooks
dan approved these changes 2023-04-20 20:40:18 +00:00
dan left a comment
Owner
Copy Link

approved pending tests

approved pending tests
buildbot commented 2023-04-20 20:52:01 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/151

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/151
sarah merged commit d9298f84b2 into master 2023-04-20 21:00:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#508
No description provided.
Delete Branch "fuzzbot"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?