cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

better handle acn/engine isntability #512

Merged
dan merged 4 commits from handleStatus into master 2023-05-01 21:47:57 +00:00
Conversation 2 Commits 4 Files Changed 4 +89 -33
dan commented 2023-04-27 21:18:49 +00:00
Owner
Copy Link
  • engine shutdown now puts potentially long blocking service.close()s in goroutine so Deactivate engine returns promtply. means app quits quickly, means we can revisit allowing deactivating engine, and means when we do call it when acn goes down, we respond quickly
  • contact retry more smartly handles protocolenginestart. I believe there were timing problems where ACNStatus = 100 might arrive before protocol engine was created meaning contact retry might not start. this should fix that potential edge case
- engine shutdown now puts potentially long blocking service.close()s in goroutine so Deactivate engine returns promtply. means app quits quickly, means we can revisit allowing deactivating engine, and means when we do call it when acn goes down, we respond quickly - contact retry more smartly handles protocolenginestart. I believe there were timing problems where ACNStatus = 100 might arrive before protocol engine was created meaning contact retry might not start. this should fix that potential edge case
dan added 1 commit 2023-04-27 21:18:50 +00:00
dan added 2 commits 2023-04-28 21:00:29 +00:00
continuous-integration/drone/pr Build is failing Details
e9e2a18678 fix?
dan changed title from engine shutdown now puts potentially long blocking service.close()s in goroutine; contact retry more smartly handles protocolengine start in case last ACNstatus == 100 message comes first to better handle acn/engine isntability 2023-04-30 16:22:03 +00:00
sarah reviewed 2023-05-01 19:26:29 +00:00
app/app.go
@ -475,2 +479,4 @@
}
func (app *application) eventHandler() {
acnStatus := -1
sarah commented 2023-05-01 19:26:29 +00:00
Owner
Copy Link

this should be a struct level member,

this should be a struct level member,
sarah reviewed 2023-05-01 19:27:52 +00:00
sarah left a comment
Owner
Copy Link

See note

See note
buildbot commented 2023-05-01 19:32:42 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/159

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/159
dan added 1 commit 2023-05-01 21:13:46 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build was killed Details
7053f4a31b remove peerlock probably left over from peerapp seperation
buildbot commented 2023-05-01 21:29:55 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/160

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/160
sarah approved these changes 2023-05-01 21:43:00 +00:00
dan merged commit 7053f4a31b into master 2023-05-01 21:47:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sarah
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#512
No description provided.
Delete Branch "handleStatus"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?