cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

Add additional information to DeleteContact event #516

Merged
sarah merged 1 commits from deletecontactfix into master 2023-06-13 17:07:02 +00:00
Conversation 1 Commits 1 Files Changed 2 +6 -1
sarah commented 2023-06-12 18:46:34 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2023-06-12 18:46:34 +00:00
sarah added 1 commit 2023-06-12 18:46:35 +00:00
continuous-integration/drone/pr Build is passing Details
86ae2a7c1a Add additional information to DeleteContact event
buildbot commented 2023-06-12 19:09:57 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/180

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/180
dan reviewed 2023-06-12 22:41:24 +00:00
testing/cwtch_peer_server_integration_test.go
@ -386,0 +386,4 @@
// Have bob clean up some conversations...
log.Infof("Bob cleanup conversation")
bob.DeleteConversation(1)
dan commented 2023-06-12 22:41:24 +00:00
Owner
Copy Link

add time.Sleep(1) so that we dont just test teh event fires to bus but it gets picked up

add `time.Sleep(1)` so that we dont just test teh event fires to bus but it gets picked up
sarah commented 2023-06-13 17:06:56 +00:00
Author
Owner
Copy Link

DeleteConversation is atomic.

DeleteConversation is atomic.
dan approved these changes 2023-06-12 22:41:37 +00:00
dan left a comment
Owner
Copy Link

approved pending comment

approved pending comment
sarah merged commit 655b1cf208 into master 2023-06-13 17:07:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#516
No description provided.
Delete Branch "deletecontactfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?