cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

Support Appear Offline / Disconnect from Server/Peer #531

Merged
sarah merged 4 commits from stable-blockers into master 2023-09-13 18:49:10 +00:00
Conversation 2 Commits 4 Files Changed 11 +102 -56
sarah commented 2023-09-13 17:07:54 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2023-09-13 17:07:54 +00:00
sarah added 1 commit 2023-09-13 17:07:55 +00:00
continuous-integration/drone/pr Build was killed Details
e311301d72 Support Appear Offline / Disconnect from Server/Peer
dan reviewed 2023-09-13 17:10:17 +00:00
app/app.go
@ -64,3 +64,3 @@
QueryACNVersion()
ActivateEngines(doListn, doPeers, doServers bool)
ConfigureConnections(onion string, doListn, doPeers, doServers bool)
dan commented 2023-09-13 17:10:17 +00:00
Owner
Copy Link

do we want to drop ActivatePeerEngine(onion string) then? or make this activatePeerEngine?

do we want to drop `ActivatePeerEngine(onion string)` then? or make this activatePeerEngine?
sarah commented 2023-09-13 17:24:02 +00:00
Author
Owner
Copy Link

ActivatePeerEngine initializes the actual engine, then configure the connections operates over that.

ActivatePeerEngine initializes the actual engine, then configure the connections operates over that.
dan reviewed 2023-09-13 17:12:17 +00:00
dan reviewed 2023-09-13 17:16:59 +00:00
dan left a comment
Owner
Copy Link

do we have a way to turn off a peer that's started active, that fires all the disconnect events so it can be started back up invisible and connectRetry wont go ham retrying. you added DisconnectFromPeer but i'm not sure it makes sense to have the looping and disconnect logic in the UI? should be wired into shutdown here... oh wait, does shutdown just delete the contactRety plugin? then that'd be fine

(i ask cus use case is ppl turn on cwtch, all peers connect and they turn one off to enable invibisble mode. also we should wire the invisible button to shutdown and restart the peer in invisible, there's no other transition state right?)

do we have a way to turn off a peer that's started active, that fires all the disconnect events so it can be started back up invisible and connectRetry wont go ham retrying. you added `DisconnectFromPeer` but i'm not sure it makes sense to have the looping and disconnect logic in the UI? should be wired into shutdown here... oh wait, does shutdown just delete the contactRety plugin? then that'd be fine (i ask cus use case is ppl turn on cwtch, all peers connect and they turn one off to enable invibisble mode. also we should wire the invisible button to shutdown and restart the peer in invisible, there's no other transition state right?)
sarah commented 2023-09-13 17:23:19 +00:00
Author
Owner
Copy Link

do we have a way to turn off a peer that's started active, that fires all the disconnect events so it can be started back up invisible and connectRetry wont go ham retrying. you added DisconnectFromPeer but i'm not sure it makes sense to have the looping and disconnect logic in the UI? should be wired into shutdown here... oh wait, does shutdown just delete the contactRety plugin? then that'd be fine

(i ask cus use case is ppl turn on cwtch, all peers connect and they turn one off to enable invibisble mode. also we should wire the invisible button to shutdown and restart the peer in invisible, there's no other transition state right?)

Yeah we can just toggle Deactivate and Activate

> do we have a way to turn off a peer that's started active, that fires all the disconnect events so it can be started back up invisible and connectRetry wont go ham retrying. you added `DisconnectFromPeer` but i'm not sure it makes sense to have the looping and disconnect logic in the UI? should be wired into shutdown here... oh wait, does shutdown just delete the contactRety plugin? then that'd be fine > > (i ask cus use case is ppl turn on cwtch, all peers connect and they turn one off to enable invibisble mode. also we should wire the invisible button to shutdown and restart the peer in invisible, there's no other transition state right?) Yeah we can just toggle Deactivate and Activate
sarah added 1 commit 2023-09-13 17:30:47 +00:00
continuous-integration/drone/pr Build was killed Details
a5cea1ca7b ConfigureConnections in Tests
sarah added 1 commit 2023-09-13 17:49:48 +00:00
continuous-integration/drone/pr Build is passing Details
7538f1a531 Enable Group Experiment in Main Test
buildbot commented 2023-09-13 18:07:30 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/243

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/243
dan reviewed 2023-09-13 18:48:00 +00:00
testing/cwtch_peer_server_integration_test.go Outdated
@ -150,6 +150,12 @@ func TestCwtchPeerIntegration(t *testing.T) {
numGoRoutinesPostAppStart := runtime.NumGoroutine()
// ***** cwtchPeer setup *****
// Turn on File Sharing Experiment...
dan commented 2023-09-13 18:48:00 +00:00
Owner
Copy Link

Groups experiment

Groups experiment
dan approved these changes 2023-09-13 18:48:12 +00:00
sarah added 1 commit 2023-09-13 18:48:55 +00:00
continuous-integration/drone/pr Build is pending Details
f42e25e926 Typo Fix
sarah merged commit 45d6d76a7d into master 2023-09-13 18:49:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#531
No description provided.
Delete Branch "stable-blockers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?