cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

First Cut of Enhanced Permissions #543

Merged
sarah merged 4 commits from enhanced-permissions into master 2024-01-15 18:04:35 +00:00
Conversation 1 Commits 4 Files Changed 8 +184 -30
sarah commented 2024-01-08 20:54:26 +00:00
Owner
Copy Link
No description provided.
sarah force-pushed enhanced-permissions from 91b5097ee7 to a88e765686 2024-01-08 20:56:08 +00:00 Compare
sarah force-pushed enhanced-permissions from a88e765686 to 665c840a41 2024-01-08 20:56:45 +00:00 Compare
sarah force-pushed enhanced-permissions from 665c840a41 to 53109ba84e 2024-01-08 20:57:03 +00:00 Compare
sarah force-pushed enhanced-permissions from 53109ba84e to f25f97aca2 2024-01-08 20:57:23 +00:00 Compare
sarah force-pushed enhanced-permissions from f25f97aca2 to 8702f5b4d4 2024-01-08 21:08:54 +00:00 Compare
sarah force-pushed enhanced-permissions from 8702f5b4d4 to 8e72534081 2024-01-08 21:21:08 +00:00 Compare
sarah force-pushed enhanced-permissions from 8e72534081 to 1c7003fb96 2024-01-08 21:22:45 +00:00 Compare
sarah added 1 commit 2024-01-08 21:26:13 +00:00
continuous-integration/drone/pr Build is passing Details
41b3e20aff Remove Flakey Queued Check in Contact Retry Plugin Test
buildbot commented 2024-01-08 21:46:36 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/304

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/304
sarah changed title from WIP: First Cut of Enhanced Permissions to First Cut of Enhanced Permissions 2024-01-08 21:54:51 +00:00
dan reviewed 2024-01-11 03:23:10 +00:00
dan left a comment
Owner
Copy Link

looks pretty good, two minor questions

looks pretty good, two minor questions
peer/cwtch_peer.go
@ -312,2 +312,4 @@
for _, conversation := range conversations {
if tor.IsValidHostname(conversation.Handle) {
dan commented 2024-01-11 03:20:22 +00:00
Owner
Copy Link

Add comment calling this section upgrading attributes v0 to v1

Add comment calling this section upgrading attributes v0 to v1
dan marked this conversation as resolved
peer/profile_interface.go Outdated
@ -123,0 +123,4 @@
// API-level management of conversation access control
UpdateConversationAccessControlList(id int, acl model.AccessControlList) error
EnhancedGetConversationAccessControlList(conversation int) (string, error)
dan commented 2024-01-11 03:22:55 +00:00
Owner
Copy Link

How come UpdateConversationAccessControlList takes an model.AccessControlList but EnhancedGetConversationAccessControlList isn't called just GetConversationAccessControlList and how come it returns only a string of json?

How come UpdateConversationAccessControlList takes an model.AccessControlList but EnhancedGetConversationAccessControlList isn't called just GetConversationAccessControlList and how come it returns only a string of json?
sarah commented 2024-01-11 03:27:56 +00:00
Author
Owner
Copy Link

Enhanced has special meaning in autobindings that aligns to how memory is managed. It returns JSON because the UI will mediate in json.

UpdateConversationAccessControlList is a go interface to be used in cwtch extensions.

`Enhanced` has special meaning in autobindings that aligns to how memory is managed. It returns JSON because the UI will mediate in json. UpdateConversationAccessControlList is a go interface to be used in cwtch extensions.
dan commented 2024-01-11 03:30:55 +00:00
Owner
Copy Link

ah ok right now i see get/set for acl via json but only set for the model.acl, is there a get for that in the api for go/cwtch code?

ah ok right now i see get/set for acl via json but only set for the model.acl, is there a get for that in the api for go/cwtch code?
dan marked this conversation as resolved
dan approved these changes 2024-01-11 03:34:16 +00:00
dan left a comment
Owner
Copy Link

approved pendiong one comment and one get acl mode function in the interface

approved pendiong one comment and one get acl mode function in the interface
sarah added 1 commit 2024-01-11 18:02:41 +00:00
continuous-integration/drone/pr Build is pending Details
d66beb95e5 Update APIs, Formatting
sarah added 1 commit 2024-01-11 18:06:31 +00:00
continuous-integration/drone/pr Build is pending Details
b0a87ee8d0 Move comment for better understanding
sarah merged commit aaabb12b6c into master 2024-01-15 18:04:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#543
No description provided.
Delete Branch "enhanced-permissions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?