Introduce Channel/Overlay Mappings #549
No reviewers
Labels
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/cwtch#549
Loading…
Reference in New Issue
No description provided.
Delete Branch "overlays"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch/313
@ -6,1 +10,4 @@
Data string `json:"d"`
// when the data was assembled
SendTime time.Time `json:"s,omitempty"`
bad news
https://stackoverflow.com/questions/32643815/json-omitempty-with-time-time-field
confirmed with a quick test
and
we don't want to be padding our messages with 3 time stamps one only filled on receipt
@ -148,6 +158,15 @@ func (pa *PeerApp) SendMessage(message model2.PeerMessage) error {
var serialized []byte
var err error
if cm, err := model.DeserializeMessage(string(message.Data)); err == nil {
if cm, err := model.DeserializeMessage(string(message.Data)); err == nil && cm != nil {
then delete if below
@ -133,6 +135,14 @@ func (pa *PeerApp) listen() {
pa.version.Store(Version2)
}
} else {
if cm, err := model.DeserializeMessage(string(packet.Data)); err == nil {
if cm, err := model.DeserializeMessage(string(packet.Data)); err == nil && cm != nil {
and delete if below
@ -443,0 +438,4 @@
// check if we should store this message locally...
if cm, err := model.DeserializeMessage(message); err == nil {
if cm.Overlay < 1024 || cm.Overlay&0x7 != 0x7 {
whats up with < 1024 and not 7?
your last pr had things partitioned along 0x300 i believe?
can we make these some constants