cwtch.im
/
libcwtch-go
Archived
3
0
Fork 1
Code Issues 2 Pull Requests Releases 26 Wiki Activity

Convert to new ScopedZone Interface #34

Merged
dan merged 4 commits from scopezone into trunk 2021-10-27 19:52:26 +00:00
Conversation 4 Commits 4 Files Changed 6 +110 -85
sarah commented 2021-10-15 18:00:57 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2021-10-15 18:00:57 +00:00
sarah changed title from Convert to new ScopedZone Interface to WIP: Convert to new ScopedZone Interface 2021-10-15 18:01:10 +00:00
sarah changed title from WIP: Convert to new ScopedZone Interface to Convert to new ScopedZone Interface 2021-10-15 20:10:11 +00:00
buildbot commented 2021-10-15 20:24:49 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/libcwtch-go/99

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/99
buildbot commented 2021-10-15 20:24:49 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/libcwtch-go/100

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/100
sarah force-pushed scopezone from 50430f0a96 to cc45561dd5 2021-10-15 20:48:36 +00:00 Compare
buildbot commented 2021-10-15 20:50:57 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/libcwtch-go/101

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/101
dan reviewed 2021-10-26 00:21:37 +00:00
utils/eventHandler.go Outdated
@ -97,2 +92,2 @@
profile.SetAttribute(attr.GetPublicScope(constants.Name), name)
profile.SetAttribute(attr.GetPublicScope(constants.Picture), ImageToString(NewImage(RandomProfileImage(onion), TypeImageDistro)))
name, _ := profile.GetScopedZonedAttribute(attr.LocalScope, attr.ProfileZone, constants.Name)
profile.SetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name, name)
dan commented 2021-10-26 00:19:51 +00:00
Owner

redundant (see below) also why are we storing name in local and then here copying it to public. why not just have it set it as a public value since its main function is to be fetched and displayed by otherS?

redundant (see below) also why are we storing name in local and then here copying it to public. why not just have it set it as a public value since its main function is to be fetched and displayed by otherS?
utils/eventHandler.go Outdated
@ -120,3 +116,3 @@
}
nick, exists := profile.GetAttribute(attr.GetPublicScope(constants.Name))
nick, exists := profile.GetScopedZonedAttribute(attr.LocalScope, attr.ProfileZone, constants.Name)
dan commented 2021-10-26 00:20:13 +00:00
Owner

maybe incorporate this step with the above and below?

maybe incorporate this step with the above and below?
utils/eventHandler.go Outdated
@ -136,2 +132,3 @@
//tag, _ := profile.GetAttribute(app.AttributeTag)
// Set publicly scopes attributes
profile.SetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name, nick)
dan commented 2021-10-26 00:19:09 +00:00
Owner

redundant?

redundant?
sarah force-pushed scopezone from cc45561dd5 to a3e3c221ca 2021-10-27 16:35:47 +00:00 Compare
buildbot commented 2021-10-27 19:46:40 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/libcwtch-go/102

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/102
dan merged commit 9fdbd45bb2 into trunk 2021-10-27 19:52:26 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/libcwtch-go#34
No description provided.
Delete Branch "scopezone"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?