Convert to new ScopedZone Interface #34

Merged
dan merged 4 commits from scopezone into trunk 1 month ago
sarah commented 1 month ago
Owner
There is no content yet.
dan was assigned by sarah 1 month ago
sarah changed title from Convert to new ScopedZone Interface to WIP: Convert to new ScopedZone Interface 1 month ago
sarah changed title from WIP: Convert to new ScopedZone Interface to Convert to new ScopedZone Interface 1 month ago
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/99
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/100
sarah force-pushed scopezone from 50430f0a96 to cc45561dd5 1 month ago
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/101
dan reviewed 1 month ago
profile.SetAttribute(attr.GetPublicScope(constants.Name), name)
profile.SetAttribute(attr.GetPublicScope(constants.Picture), ImageToString(NewImage(RandomProfileImage(onion), TypeImageDistro)))
name, _ := profile.GetScopedZonedAttribute(attr.LocalScope, attr.ProfileZone, constants.Name)
profile.SetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name, name)
dan commented 1 month ago
Poster
Owner

redundant (see below) also why are we storing name in local and then here copying it to public. why not just have it set it as a public value since its main function is to be fetched and displayed by otherS?

redundant (see below) also why are we storing name in local and then here copying it to public. why not just have it set it as a public value since its main function is to be fetched and displayed by otherS?
}
nick, exists := profile.GetAttribute(attr.GetPublicScope(constants.Name))
nick, exists := profile.GetScopedZonedAttribute(attr.LocalScope, attr.ProfileZone, constants.Name)
dan commented 1 month ago
Poster
Owner

maybe incorporate this step with the above and below?

maybe incorporate this step with the above and below?
//tag, _ := profile.GetAttribute(app.AttributeTag)
// Set publicly scopes attributes
profile.SetScopedZonedAttribute(attr.PublicScope, attr.ProfileZone, constants.Name, nick)
dan commented 1 month ago
Poster
Owner

redundant?

redundant?
sarah force-pushed scopezone from cc45561dd5 to a3e3c221ca 1 month ago
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/libcwtch-go/102
dan merged commit 9fdbd45bb2 into trunk 1 month ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 9fdbd45bb2.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.