Redesign: contact Row and Picture: themeing and modularizing: #276
No reviewers
Labels
No Label
1app
2 apps
accessibility
android
before-beta
bug
duplicate
enhancement
first-contact
fixed
help wanted
infrastructure
invalid
low-priority
must-fix
needs testing
nice-to-have
question
tor
user-feedback
wontfix
No Milestone
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/ui#276
Loading…
Reference in New Issue
No description provided.
Delete Branch ":03-widgets"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Redesign: contact Row and Picture: themeing and modularizing:
to theme colors...) And adding the new accept/reject new contact
workflow
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/ui/523
awesome, I'll dig into this
responses
asking marcia
if so: textMetric code to be put back in... but width is decoupled, the filler content is in contactRow and badge width initially set in Badge... so that'll be something for me to figure out
fixed
-_-;
some things in the attached screenshot:
long profile names and onion strings cross the scrollbar
TODO
the profile images in the message pane seem to be of varying sizes for some reason?
profile images in the message pane have an empty white badge
in general, not necessarily for this PR: this diff was somewhat hard to review because our indentation is getting messier over time... can we get a formatting tool involved? would either https://github.com/jesperhh/qmlfmt or https://github.com/Orange-OpenSource/qmljsreformatter work with our process? both annoyingly appear to replace tabs with spaces but i'm willing to trade one pain for the other in this case lol
fixed
now elipsis dynamically
badge dimensions stay fixed but as per marcia, number caps at string "99+" which fits
To be addressed in message pane PR
scheduling for seperate PR cus... all the red/green as all the whitespace changes
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/ui/524