cwtch.im
/
ui
Archived
6
7
포크 2
코드 이슈 64 풀 리퀘스트 2 릴리즈 9 위키 활동

Android Back button like home button #212

병합
erinn :androidBack 에서 master 로 2 commits 를 머지했습니다 2019-09-13 23:24:59 +00:00
대화 8 커밋 2 파일 변경됨 4 +41 -4
dan 코멘트됨, 2019-09-06 01:37:27 +00:00
소유자
Copy Link

Android back button default behaviour on root pane is to exit that app. That's not ideal so I've captured it and redirected to a home button like behaviour

It might be nice to have it do pane switching when not at root?

Android back button default behaviour on root pane is to exit that app. That's not ideal so I've captured it and redirected to a home button like behaviour It might be nice to have it do pane switching when not at root?
buildbot 코멘트됨, 2019-09-06 01:40:30 +00:00
멤버
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/318

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/318
buildbot 코멘트됨, 2019-09-06 01:43:36 +00:00
멤버
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/319

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/319
erinn 다음으로부터 할당취소됨 dan 2019-09-11 18:03:06 +00:00
erinn 다음으로부터 할당됨 dan 2019-09-11 18:03:10 +00:00
erinn 코멘트됨, 2019-09-13 23:09:40 +00:00
소유자
Copy Link

updated back button handling (not very robust but i'm planning a layout manager change that will break this anyway so it's fine for now):
Keys.onPressed: {
if (event.key == Qt.Key_Back) {
event.accepted = true
if (theStack.currentIndex == theStack.emptyPane) {
androidCwtchActivity.rootHomeButtonHandle()
} else if (theStack.currentIndex == theStack.userProfilePane || theStack.currentIndex == theStack.groupProfilePane) {
theStack.currentIndex = theStack.messagePane
} else {
theStack.currentIndex = theStack.emptyPane
}
}
}
'''

updated back button handling (not very robust but i'm planning a layout manager change that will break this anyway so it's fine for now): Keys.onPressed: { if (event.key == Qt.Key_Back) { event.accepted = true if (theStack.currentIndex == theStack.emptyPane) { androidCwtchActivity.rootHomeButtonHandle() } else if (theStack.currentIndex == theStack.userProfilePane || theStack.currentIndex == theStack.groupProfilePane) { theStack.currentIndex = theStack.messagePane } else { theStack.currentIndex = theStack.emptyPane } } } '''
erinn requested changes 2019-09-13 23:15:34 +00:00
go/gothings/android/CwtchActivity.go Outdated
@ -14,2 +15,4 @@
_ func(string) `slot:"updateAndroidNotification"`
_ func() `signal:"rootHomeButtonHandle,auto""`
erinn 코멘트됨, 2019-09-13 23:14:01 +00:00
소유자

remove double-double-quote near eol

remove double-double-quote near eol
dan 코멘트됨, 2019-09-13 23:18:28 +00:00
Author
소유자
Copy Link

added

fixed!

thanks

added fixed! thanks
buildbot 코멘트됨, 2019-09-13 23:20:07 +00:00
멤버
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/333

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/333
buildbot 코멘트됨, 2019-09-13 23:20:08 +00:00
멤버
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/332

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/332
erinn 이 변경사항을 승인하였습니다. 2019-09-13 23:21:24 +00:00
buildbot 코멘트됨, 2019-09-13 23:23:16 +00:00
멤버
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/335

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/335
buildbot 코멘트됨, 2019-09-13 23:23:16 +00:00
멤버
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/334

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/334
erinn closed this pull request 2019-09-13 23:24:59 +00:00
This repo is archived. You cannot comment on pull requests.
리뷰어
No reviewers
레이블
레이블 초기화   
1app

   
2 apps

   
accessibility

   
android

   
before-beta

issues that need to be fixed before beta

  
bug

   
duplicate

   
enhancement

   
first-contact

   
fixed

   
help wanted

   
infrastructure

   
invalid

   
low-priority

   
must-fix

   
needs testing

issues that are presumed fixed but need testing

  
nice-to-have

   
question

   
tor

   
user-feedback

   
wontfix
레이블 없음
1app
2 apps
accessibility
android
before-beta
bug
duplicate
enhancement
first-contact
fixed
help wanted
infrastructure
invalid
low-priority
must-fix
needs testing
nice-to-have
question
tor
user-feedback
wontfix
마일스톤
마일스톤 초기화
No items
마일스톤 없음
담당자
담당자 초기화
담당자 없음
erinn
참여자 3명
마감일
기한이 올바르지 않거나 범위를 벗어났습니다. 'yyyy-mm-dd'형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: cwtch.im/ui#212
No description provided.
Delete Branch ":androidBack"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?