cwtch.im
/
ui
Archived
6
7
포크 2
코드 이슈 64 풀 리퀘스트 2 릴리즈 9 위키 활동

Using new cwtch attributes and get/ret val requests #272

병합
sarah :keyval 에서 master 로 1 commits 를 머지했습니다 2020-03-31 19:06:38 +00:00
대화 4 커밋 1 파일 변경됨 11 +319 -124
dan 코멘트됨, 2020-03-19 21:16:42 +00:00
소유자
Copy Link
No description provided.
buildbot 코멘트됨, 2020-03-28 00:26:21 +00:00
멤버
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/508

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/508
buildbot 코멘트됨, 2020-03-28 16:16:42 +00:00
멤버
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/509

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/509
dan changed title from WIP: Using new cwtch attributes and get/ret val requests to Using new cwtch attributes and get/ret val requests 2020-03-30 16:17:59 +00:00
buildbot 코멘트됨, 2020-03-30 16:22:53 +00:00
멤버
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/510

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/510
sarah requested changes 2020-03-30 18:37:04 +00:00
go/handlers/peerHandler.go Outdated
@ -93,0 +99,4 @@
}
}
case event.NewRetValMessageFromPeer:
// TODO: update the ui
sarah 코멘트됨, 2020-03-30 18:15:38 +00:00
소유자

?

?
dan 코멘트됨, 2020-03-30 20:57:27 +00:00
Author
소유자

oph, reminder to myself i didnt delete after I filled the case:

oph, reminder to myself i didnt delete after I filled the case:
go/ui/gcd.go Outdated
@ -331,0 +327,4 @@
if !exists {
zoom = "1.0"
}
locale, exists := the.Peer.GetAttribute(attr.GetSettingsScope(constants.LocaleSetting))
sarah 코멘트됨, 2020-03-30 18:34:18 +00:00
소유자

I feel we need a better way of managing defaults than this.

I feel we need a better way of managing defaults than this.
dan 코멘트됨, 2020-03-30 21:00:24 +00:00
Author
소유자

we were doing nothing. open to suggestions. we don't really have a good handle yet on what our settings will ultimatly be, we need to work on our settings management some. Erinn has some ideas on this

we were doing nothing. open to suggestions. we don't really have a good handle yet on what our settings will ultimatly be, we need to work on our settings management some. Erinn has some ideas on this
go/ui/imageType.go Outdated
@ -0,0 +3,4 @@
import "encoding/json"
const (
TypeImageDistro = "distro"
sarah 코멘트됨, 2020-03-30 18:34:53 +00:00
소유자

wat? needs documentation

wat? needs documentation
go/ui/manager.go Outdated
@ -57,0 +69,4 @@
log.Infof("get nick for contact %v\n", id)
nick, exists := the.Peer.GetContactAttribute(id, attr.GetLocalScope(constants.Name))
if !exists {
log.Infof("local !exits\n")
sarah 코멘트됨, 2020-03-30 18:35:26 +00:00
소유자

remove infos

remove infos
go/ui/manager.go Outdated
@ -57,0 +72,4 @@
log.Infof("local !exits\n")
nick, exists = the.Peer.GetContactAttribute(id, attr.GetPeerScope(constants.Name))
if !exists {
log.Infof("peer !exists\n")
sarah 코멘트됨, 2020-03-30 18:35:36 +00:00
소유자

and this one

and this one
go/ui/manager.go Outdated
@ -85,3 +103,1 @@
return RandomGroupImage(id)
} else {
return profilePicRelativize(pic)
log.Debugln("is group")
sarah 코멘트됨, 2020-03-30 18:36:02 +00:00
소유자

remove overly verbose debug statements like this one

remove overly verbose debug statements like this one
go/ui/manager.go Outdated
@ -97,1 +135,4 @@
func getPicturePath(pic *image) string {
log.Debugf("getPicturePath for %v\n", pic)
if pic.T == TypeImageDistro {
sarah 코멘트됨, 2020-03-30 18:36:29 +00:00
소유자

should be a switch statement with a default

should be a switch statement with a default
buildbot 코멘트됨, 2020-03-30 21:20:29 +00:00
멤버
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/511

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/511
sarah closed this pull request 2020-03-31 19:06:38 +00:00
This repo is archived. You cannot comment on pull requests.
리뷰어
No reviewers
레이블
레이블 초기화   
1app

   
2 apps

   
accessibility

   
android

   
before-beta

issues that need to be fixed before beta

  
bug

   
duplicate

   
enhancement

   
first-contact

   
fixed

   
help wanted

   
infrastructure

   
invalid

   
low-priority

   
must-fix

   
needs testing

issues that are presumed fixed but need testing

  
nice-to-have

   
question

   
tor

   
user-feedback

   
wontfix
레이블 없음
1app
2 apps
accessibility
android
before-beta
bug
duplicate
enhancement
first-contact
fixed
help wanted
infrastructure
invalid
low-priority
must-fix
needs testing
nice-to-have
question
tor
user-feedback
wontfix
마일스톤
마일스톤 초기화
No items
마일스톤 없음
담당자
담당자 초기화
담당자 없음
참여자 3명
마감일
기한이 올바르지 않거나 범위를 벗어났습니다. 'yyyy-mm-dd'형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: cwtch.im/ui#272
No description provided.
Delete Branch ":keyval"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?