cwtch.im
/
ui
Gearchiveerd
6
7
Vork 2
Code Kwesties 64 Pull-aanvragen 2 Publicaties 9 Wiki Activiteit

Using new cwtch attributes and get/ret val requests #272

Samengevoegd
sarah heeft 1 commits samengevoegd van :keyval naar master 2020-03-31 19:06:38 +00:00
Discussie 4 Commits 1 Bestanden gewijzigd 11 +319 -124
dan reageerde 2020-03-19 21:16:42 +00:00
Eigenaar
Link kopiëren
No description provided.
buildbot reageerde 2020-03-28 00:26:21 +00:00
Lid
Link kopiëren

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/508

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/508
buildbot reageerde 2020-03-28 16:16:42 +00:00
Lid
Link kopiëren

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/509

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/509
dan titel aangepast van WIP: Using new cwtch attributes and get/ret val requests naar Using new cwtch attributes and get/ret val requests 2020-03-30 16:17:59 +00:00
buildbot reageerde 2020-03-30 16:22:53 +00:00
Lid
Link kopiëren

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/510

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/510
sarah aangevraagde wijzigingen 2020-03-30 18:37:04 +00:00
go/handlers/peerHandler.go Verouderd
@ -93,0 +99,4 @@
}
}
case event.NewRetValMessageFromPeer:
// TODO: update the ui
sarah reageerde 2020-03-30 18:15:38 +00:00
Eigenaar

?

?
dan reageerde 2020-03-30 20:57:27 +00:00
Author
Eigenaar

oph, reminder to myself i didnt delete after I filled the case:

oph, reminder to myself i didnt delete after I filled the case:
go/ui/gcd.go Verouderd
@ -331,0 +327,4 @@
if !exists {
zoom = "1.0"
}
locale, exists := the.Peer.GetAttribute(attr.GetSettingsScope(constants.LocaleSetting))
sarah reageerde 2020-03-30 18:34:18 +00:00
Eigenaar

I feel we need a better way of managing defaults than this.

I feel we need a better way of managing defaults than this.
dan reageerde 2020-03-30 21:00:24 +00:00
Author
Eigenaar

we were doing nothing. open to suggestions. we don't really have a good handle yet on what our settings will ultimatly be, we need to work on our settings management some. Erinn has some ideas on this

we were doing nothing. open to suggestions. we don't really have a good handle yet on what our settings will ultimatly be, we need to work on our settings management some. Erinn has some ideas on this
go/ui/imageType.go Verouderd
@ -0,0 +3,4 @@
import "encoding/json"
const (
TypeImageDistro = "distro"
sarah reageerde 2020-03-30 18:34:53 +00:00
Eigenaar

wat? needs documentation

wat? needs documentation
go/ui/manager.go Verouderd
@ -57,0 +69,4 @@
log.Infof("get nick for contact %v\n", id)
nick, exists := the.Peer.GetContactAttribute(id, attr.GetLocalScope(constants.Name))
if !exists {
log.Infof("local !exits\n")
sarah reageerde 2020-03-30 18:35:26 +00:00
Eigenaar

remove infos

remove infos
go/ui/manager.go Verouderd
@ -57,0 +72,4 @@
log.Infof("local !exits\n")
nick, exists = the.Peer.GetContactAttribute(id, attr.GetPeerScope(constants.Name))
if !exists {
log.Infof("peer !exists\n")
sarah reageerde 2020-03-30 18:35:36 +00:00
Eigenaar

and this one

and this one
go/ui/manager.go Verouderd
@ -85,3 +103,1 @@
return RandomGroupImage(id)
} else {
return profilePicRelativize(pic)
log.Debugln("is group")
sarah reageerde 2020-03-30 18:36:02 +00:00
Eigenaar

remove overly verbose debug statements like this one

remove overly verbose debug statements like this one
go/ui/manager.go Verouderd
@ -97,1 +135,4 @@
func getPicturePath(pic *image) string {
log.Debugf("getPicturePath for %v\n", pic)
if pic.T == TypeImageDistro {
sarah reageerde 2020-03-30 18:36:29 +00:00
Eigenaar

should be a switch statement with a default

should be a switch statement with a default
buildbot reageerde 2020-03-30 21:20:29 +00:00
Lid
Link kopiëren

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/511

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/511
sarah heeft deze pull request gesloten 2020-03-31 19:06:38 +00:00
Deze repo is gearchiveerd. U kunt niet reageren op pull requests.
Reviewers
Geen beoordelaars
Labels
Verwijder labels   
1app

   
2 apps

   
accessibility

   
android

   
before-beta

issues that need to be fixed before beta

  
bug

   
duplicate

   
enhancement

   
first-contact

   
fixed

   
help wanted

   
infrastructure

   
invalid

   
low-priority

   
must-fix

   
needs testing

issues that are presumed fixed but need testing

  
nice-to-have

   
question

   
tor

   
user-feedback

   
wontfix
Geen label
1app
2 apps
accessibility
android
before-beta
bug
duplicate
enhancement
first-contact
fixed
help wanted
infrastructure
invalid
low-priority
must-fix
needs testing
nice-to-have
question
tor
user-feedback
wontfix
Mijlpaal
Verwijder mijlpaal
Geen items
Geen mijlpaal
Toegewezen aan
Verwijder toegewezen aan
Niet toegewezen
3 deelnemers
Vervaldatum
De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: cwtch.im/ui#272
No description provided.
Delete Branch ":keyval"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?