cwtch.im
/
ui
Archived
6
7
Fork 2
Code Issues 64 Pull Requests 2 Releases 9 Wiki Activity

add name on profile create #357

Merged
sarah merged 1 commits from :createProfileName into master 2020-11-03 20:48:20 +00:00
Conversation 4 Commits 1 Files Changed 13 +149 -97
dan commented 2020-11-02 22:45:34 +00:00
Owner
Copy Link

requires: cwtch.im/cwtch#329

  • also color error on 0 profiles loaded with password message on profile manager
requires: https://git.openprivacy.ca/cwtch.im/cwtch/pulls/329 - also color error on 0 profiles loaded with password message on profile manager
dan changed title from add name on profile create to WIP: add name on profile create 2020-11-02 22:45:42 +00:00
buildbot commented 2020-11-02 22:48:16 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/738

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/738
buildbot commented 2020-11-03 00:31:23 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/739

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/739
dan changed title from WIP: add name on profile create to add name on profile create 2020-11-03 00:31:37 +00:00
sarah approved these changes 2020-11-03 20:14:46 +00:00
qml/panes/ProfileAddEditPane.qml Outdated
@ -33,3 +33,3 @@
mode = mode_add
reset_errors()
txtProfileName.text = qsTr("default-profile-name")
txtProfileName.text = "" //qsTr("default-profile-name")
sarah commented 2020-11-03 20:14:35 +00:00
Owner

why commented out?

why commented out?
dan commented 2020-11-03 20:32:56 +00:00
Author
Owner

there is now placeholder text. deleted

there is now placeholder text. deleted
dan marked this conversation as resolved
qml/panes/ProfileAddEditPane.qml Outdated
@ -252,3 +252,2 @@
id: txtProfileName
visible: mode == mode_edit
//Layout.fillWidth: true
//visible: mode == mode_edit
sarah commented 2020-11-03 20:14:23 +00:00
Owner

needed?

needed?
dan marked this conversation as resolved
buildbot commented 2020-11-03 20:35:26 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/740

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/740
buildbot commented 2020-11-03 20:39:49 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/741

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/741
sarah merged commit 9721999e9b into master 2020-11-03 20:48:19 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
sarah
Labels
Clear labels   
1app

   
2 apps

   
accessibility

   
android

   
before-beta

issues that need to be fixed before beta

  
bug

   
duplicate

   
enhancement

   
first-contact

   
fixed

   
help wanted

   
infrastructure

   
invalid

   
low-priority

   
must-fix

   
needs testing

issues that are presumed fixed but need testing

  
nice-to-have

   
question

   
tor

   
user-feedback

   
wontfix
No Label
1app
2 apps
accessibility
android
before-beta
bug
duplicate
enhancement
first-contact
fixed
help wanted
infrastructure
invalid
low-priority
must-fix
needs testing
nice-to-have
question
tor
user-feedback
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/ui#357
No description provided.
Delete Branch ":createProfileName"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?