flutter
/
flutter_app
6
1
Fork 0
Code Issues 14 Pull Requests Releases 1 Wiki Activity

Fix invitation wrapping #157

Merged
dan merged 3 commits from ui_fixes into trunk 2021-06-07 22:34:54 +00:00
Conversation 5 Commits 3 Files Changed 17 +120 -69
sarah commented 2021-06-05 00:05:20 +00:00
Owner
Copy Link

Fixes: #137

This is definitely better. But I'm not entirely happy with it.

Fixes: #137 This is definitely better. But I'm not entirely happy with it.
dan was assigned by sarah 2021-06-05 00:05:20 +00:00
erinn was assigned by sarah 2021-06-05 00:05:20 +00:00
buildbot commented 2021-06-05 00:08:58 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/467

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/467
buildbot commented 2021-06-07 16:27:36 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/469

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/469
buildbot commented 2021-06-07 21:19:20 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/470

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/470
buildbot commented 2021-06-07 21:19:51 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/471

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/471
dan requested changes 2021-06-07 21:49:47 +00:00
lib/widgets/invitationbubble.dart Outdated
@ -67,2 +75,3 @@
wdgDecorations = Text("Accepted!" + '\u202F');
} else if (this.rejected) {
wdgDecorations = Text("Rejected.");
wdgDecorations = Text("Rejected." + '\u202F');
dan commented 2021-06-07 21:47:16 +00:00
Owner
Copy Link

needs translations (ala AppLocalizations.of(context)!.Rejected ish)

needs translations (ala AppLocalizations.of(context)!.Rejected ish)
buildbot commented 2021-06-07 22:18:33 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/472

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/472
dan merged commit 27f8dd289e into trunk 2021-06-07 22:34:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
accessibility

   
android

bugs that are android specific

  
before-launch

   
blocked-on-external-dependency

   
bug

Something is not working

  
chat-overlay

   
document-workaround

   
double-column

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
fix-pending

   
flutter-bug

   
group-experiment

   
help wanted

Need some help

  
invalid

Something is wrong

  
invite-overlay

   
needs-testing

   
packaging

   
privacy

   
provisionally-fixed

   
question

More information is needed

  
theme

   
tor

   
windows

   
wontfix

This won't be fixed

No Label
accessibility
android
before-launch
blocked-on-external-dependency
bug
chat-overlay
document-workaround
double-column
duplicate
enhancement
fix-pending
flutter-bug
group-experiment
help wanted
invalid
invite-overlay
needs-testing
packaging
privacy
provisionally-fixed
question
theme
tor
windows
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
erinn
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: flutter/flutter_app#157
No description provided.
Delete Branch "ui_fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?