flutter
/
flutter_app
6
1
Fork 0
Code Issues 14 Pull Requests Releases 1 Wiki Activity

android process handling improvements #203

Merged
sarah merged 4 commits from countersync into trunk 2021-06-22 01:08:28 +00:00
Conversation 2 Commits 4 Files Changed 4 +74 -48
erinn commented 2021-06-22 00:57:50 +00:00
Owner
Copy Link
  • lots of additional logging so we can debug android process issues
  • add WidgetsBinding.ensureInitialized; without it the method channels sometimes don't get created correctly
  • foregroundservice notification accidentally had its notification channel removed
  • cancel all work in onDestroy
  • prune WorkManager work after cancellations and shutdowns, otherwise it tries to resume a cancelled job on app restart and refuses to start
* lots of additional logging so we can debug android process issues * add WidgetsBinding.ensureInitialized; without it the method channels sometimes don't get created correctly * foregroundservice notification accidentally had its notification channel removed * cancel all work in onDestroy * prune WorkManager work after cancellations and shutdowns, otherwise it tries to resume a cancelled job on app restart and refuses to start
sarah was assigned by erinn 2021-06-22 00:57:50 +00:00
erinn changed title from WIP: android process handling improvements to android process handling improvements 2021-06-22 00:59:12 +00:00
buildbot commented 2021-06-22 01:05:33 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/531

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/531
buildbot commented 2021-06-22 01:06:54 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/532

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/532
sarah merged commit 4e63694ebc into trunk 2021-06-22 01:08:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility

   
android

bugs that are android specific

  
before-launch

   
blocked-on-external-dependency

   
bug

Something is not working

  
chat-overlay

   
document-workaround

   
double-column

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
fix-pending

   
flutter-bug

   
group-experiment

   
help wanted

Need some help

  
invalid

Something is wrong

  
invite-overlay

   
needs-testing

   
packaging

   
privacy

   
provisionally-fixed

   
question

More information is needed

  
theme

   
tor

   
windows

   
wontfix

This won't be fixed

No Label
accessibility
android
before-launch
blocked-on-external-dependency
bug
chat-overlay
document-workaround
double-column
duplicate
enhancement
fix-pending
flutter-bug
group-experiment
help wanted
invalid
invite-overlay
needs-testing
packaging
privacy
provisionally-fixed
question
theme
tor
windows
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
sarah
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: flutter/flutter_app#203
No description provided.
Delete Branch "countersync"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?