flutter
/
flutter_app
6
1
Fork 0
Code Issues 14 Pull Requests Releases 1 Wiki Activity

WIP: First try at getting an iOS build ready #78

Closed
ineiti wants to merge 3 commits from (deleted):ios_build into trunk
pull from: (deleted):ios_build
merge into: flutter:trunk
Conversation 9 Commits 3 Files Changed 14 +217 -19
ineiti commented 2021-05-11 18:24:12 +00:00
First-time contributor
Copy Link

This is a draft PR!

It allows anybody interested to help me debug why I get no matching architecture in universal wrapper

This is a draft PR! It allows anybody interested to help me debug why I get `no matching architecture in universal wrapper`
buildbot commented 2021-05-11 18:25:38 +00:00
Owner
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/flutter/flutter_app/299

Drone Build Status: failure https://build.openprivacy.ca/flutter/flutter_app/299
sarah changed title from First try at getting an iOS build ready to WIP: First try at getting an iOS build ready 2021-05-11 19:23:15 +00:00
dan reviewed 2021-05-11 23:00:58 +00:00
dan left a comment
Owner
Copy Link

Wow this is amazing, thanks!

I'm just finishing off a bunch of build automation work, but if you have more questions I can prolly try and answer some and over the next few weeks might get more time to help support this port :)

Wow this is amazing, thanks! I'm just finishing off a bunch of build automation work, but if you have more questions I can prolly try and answer some and over the next few weeks might get more time to help support this port :)
lib/cwtch/ffi.dart Outdated
@ -66,2 +66,4 @@
} else if (Platform.isLinux) {
library = DynamicLibrary.open("libCwtch.so");
} else if (Platform.isIOS) {
print(Platform.environment);
dan commented 2021-05-11 22:59:09 +00:00
Owner
Copy Link

rm in final version

rm in final version
ineiti commented 2021-05-12 18:27:15 +00:00
Author
First-time contributor
Copy Link

done

done
ineiti marked this conversation as resolved
pubspec.lock Outdated
@ -8,3 +8,3 @@
url: "https://pub.dartlang.org"
source: hosted
version: "3.1.2"
version: "2.0.13"
dan commented 2021-05-11 23:00:10 +00:00
Owner
Copy Link

Can you elaborate on why all the packages got downgraded for your build?

We're still very WIP so we haven't quite pinned down a specific flutter version, but its the dev channel, anywhere from 2.1 to 2.3 I beleive

Can you elaborate on why all the packages got downgraded for your build? We're still very WIP so we haven't quite pinned down a specific flutter version, but its the dev channel, anywhere from 2.1 to 2.3 I beleive
ineiti commented 2021-05-12 18:27:01 +00:00
Author
First-time contributor
Copy Link

In fact this is what I get if I do

flutter pub get

so it's not on purpose - more that I do something wrong ;) I just tried to check out the trunk version, and if I do flutter pub get, it downgrades the package-versions.

I upgraded to Android Studio 4.2 and now it doesn't have this behaviour anymore.

In fact this is what I get if I do ``` flutter pub get ``` so it's not on purpose - more that I do something wrong ;) I just tried to check out the `trunk` version, and if I do `flutter pub get`, it downgrades the package-versions. I upgraded to Android Studio 4.2 and now it doesn't have this behaviour anymore.
buildbot commented 2021-05-12 18:26:32 +00:00
Owner
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/flutter/flutter_app/313

Drone Build Status: failure https://build.openprivacy.ca/flutter/flutter_app/313
ineiti commented 2021-05-12 18:28:32 +00:00
Author
First-time contributor
Copy Link

Also added Makefile and the ios/Podfile* so that people can correctly try out and help me figure out why this fails...

Also added `Makefile` and the `ios/Podfile*` so that people can correctly try out and help me figure out why this fails...
buildbot commented 2021-05-14 07:03:15 +00:00
Owner
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/flutter/flutter_app/354

Drone Build Status: failure https://build.openprivacy.ca/flutter/flutter_app/354
ineiti commented 2021-05-14 07:07:28 +00:00
Author
First-time contributor
Copy Link

Thanks to @Pleurinae from Twitter to point out that a .a library is static, and dlopen is dynamic. In the end I needed to do:

  • use DynamicLibrary.process() to get the symbols
  • add a dummy-call, so that the static library gets linked
  • make sure the go is compiled for iossimulator

Now it complains that there is no tor - which is correct, as this is the next step ;)

Thanks to @Pleurinae from Twitter to point out that a `.a` library is static, and `dlopen` is dynamic. In the end I needed to do: - use `DynamicLibrary.process()` to get the symbols - add a dummy-call, so that the static library gets linked - make sure the go is compiled for iossimulator Now it complains that there is no tor - which is correct, as this is the next step ;)
dan commented 2021-08-05 20:57:22 +00:00
Owner
Copy Link

hey you still around. sorry this got dropped in the rush to beta, but we're def looking to start proceeding on Mac support

hey you still around. sorry this got dropped in the rush to beta, but we're def looking to start proceeding on Mac support
ineiti commented 2021-08-06 06:08:28 +00:00
Author
First-time contributor
Copy Link

Hi dan, yes, still here ;) I had to take care of some projects of my own, but I would be happy to continue hacking a bit on this.

Btw, at my job we did a library using https://gitlab.torproject.org/tpo/core/arti to create a simple HTTPS request over tor. We have now an iOS Swift package and an Android maven package that exports a simple "call_arti" method. As soon as we find a good name (currently it's called arti-rest), we'll make it public.

As I didn't look into how you're using tor in your app I was wondering if that could be of interest. Or if it's easier trying to reproduce what you did on Android with iOS.

Hi dan, yes, still here ;) I had to take care of some projects of my own, but I would be happy to continue hacking a bit on this. Btw, at my job we did a library using https://gitlab.torproject.org/tpo/core/arti to create a simple HTTPS request over tor. We have now an iOS Swift package and an Android maven package that exports a simple "call_arti" method. As soon as we find a good name (currently it's called arti-rest), we'll make it public. As I didn't look into how you're using tor in your app I was wondering if that could be of interest. Or if it's easier trying to reproduce what you did on Android with iOS.
dan commented 2021-08-07 02:21:58 +00:00
Owner
Copy Link

ah cool! currently we're managing tor through https://git.openprivacy.ca/openprivacy/connectivity

so I've ported your patches to the new repos at

I should be getting those merged shortly.

However we have concern's about the viability of an iOS port, from what we've seen from Briar, having long running tor on iOS may be challenging? we'll prolly be looking at trying to get a MacOS build working first as support for it should be more straight forward once we figure out the infastructure (actually getting a mac for any of our devs, figuring out how to do automated cloud builds for it...).

But happy to merge some iOS support in the mean time for interested parties to keep experimenting with ahead of us :)

ah cool! currently we're managing tor through https://git.openprivacy.ca/openprivacy/connectivity so I've ported your patches to the new repos at - https://git.openprivacy.ca/cwtch.im/libcwtch-go/pulls/16 - https://git.openprivacy.ca/cwtch.im/cwtch-ui/pulls/140 I should be getting those merged shortly. However we have concern's about the viability of an iOS port, from what we've seen from Briar, having long running tor on iOS may be challenging? we'll prolly be looking at trying to get a MacOS build working first as support for it should be more straight forward once we figure out the infastructure (actually getting a mac for any of our devs, figuring out how to do automated cloud builds for it...). But happy to merge some iOS support in the mean time for interested parties to keep experimenting with ahead of us :)
ineiti commented 2021-08-07 05:59:03 +00:00
Author
First-time contributor
Copy Link

OK - continuing discussion there...

OK - continuing discussion there...
dan closed this pull request 2022-10-08 17:59:44 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility

   
android

bugs that are android specific

  
before-launch

   
blocked-on-external-dependency

   
bug

Something is not working

  
chat-overlay

   
document-workaround

   
double-column

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
fix-pending

   
flutter-bug

   
group-experiment

   
help wanted

Need some help

  
invalid

Something is wrong

  
invite-overlay

   
needs-testing

   
packaging

   
privacy

   
provisionally-fixed

   
question

More information is needed

  
theme

   
tor

   
windows

   
wontfix

This won't be fixed

No Label
accessibility
android
before-launch
blocked-on-external-dependency
bug
chat-overlay
document-workaround
double-column
duplicate
enhancement
fix-pending
flutter-bug
group-experiment
help wanted
invalid
invite-overlay
needs-testing
packaging
privacy
provisionally-fixed
question
theme
tor
windows
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: flutter/flutter_app#78
No description provided.
Delete Branch "(deleted):ios_build"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?