flutter
/
flutter_app
6
1
Fork 0
Code Issues 14 Pull Requests Releases 1 Wiki Activity

UI Fix Bulk #96

Merged
erinn merged 29 commits from ui_fixes into trunk 2021-05-28 22:55:22 +00:00
Conversation 22 Commits 29 Files Changed 58 +1365 -649
sarah commented 2021-05-25 00:14:06 +00:00
Owner
Copy Link

See individual commits. Most of this is upgrading to flutters null safe sdk, which means giving things types, declaring late instantiations and removing a few null checks where they existed before.

The rest is based on Marcia review.

See individual commits. Most of this is upgrading to flutters null safe sdk, which means giving things types, declaring late instantiations and removing a few null checks where they existed before. The rest is based on Marcia review.
erinn was assigned by sarah 2021-05-25 00:14:06 +00:00
buildbot commented 2021-05-25 00:17:46 +00:00
Owner
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/flutter/flutter_app/375

Drone Build Status: failure https://build.openprivacy.ca/flutter/flutter_app/375
buildbot commented 2021-05-25 00:20:26 +00:00
Owner
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/flutter/flutter_app/376

Drone Build Status: failure https://build.openprivacy.ca/flutter/flutter_app/376
buildbot commented 2021-05-25 00:23:25 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/377

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/377
buildbot commented 2021-05-25 00:41:45 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/378

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/378
buildbot commented 2021-05-25 01:13:03 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/379

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/379
dan approved these changes 2021-05-25 19:23:42 +00:00
dan left a comment
Owner
Copy Link

LGTM but I'm not the flutter expert. still have the performance issues and it's still building with Null Safety if you had been looking to fully remove that?

LGTM but I'm not the flutter expert. still have the performance issues and it's still building with Null Safety if you had been looking to fully remove that?
buildbot commented 2021-05-25 20:47:02 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/380

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/380
buildbot commented 2021-05-25 22:07:56 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/381

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/381
buildbot commented 2021-05-26 00:05:59 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/382

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/382
buildbot commented 2021-05-26 17:10:36 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/383

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/383
buildbot commented 2021-05-26 20:00:43 +00:00
Owner
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/flutter/flutter_app/384

Drone Build Status: failure https://build.openprivacy.ca/flutter/flutter_app/384
buildbot commented 2021-05-26 21:06:09 +00:00
Owner
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/flutter/flutter_app/385

Drone Build Status: failure https://build.openprivacy.ca/flutter/flutter_app/385
buildbot commented 2021-05-26 21:19:53 +00:00
Owner
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/flutter/flutter_app/386

Drone Build Status: failure https://build.openprivacy.ca/flutter/flutter_app/386
buildbot commented 2021-05-26 22:17:50 +00:00
Owner
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/flutter/flutter_app/387

Drone Build Status: failure https://build.openprivacy.ca/flutter/flutter_app/387
buildbot commented 2021-05-26 22:47:36 +00:00
Owner
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/flutter/flutter_app/388

Drone Build Status: failure https://build.openprivacy.ca/flutter/flutter_app/388
buildbot commented 2021-05-26 22:55:10 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/389

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/389
buildbot commented 2021-05-26 23:05:40 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/390

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/390
buildbot commented 2021-05-27 00:52:20 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/391

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/391
buildbot commented 2021-05-27 20:32:30 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/392

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/392
sarah changed title from UI Fix Bulk to WIP: UI Fix Bulk 2021-05-28 09:14:58 +00:00
buildbot commented 2021-05-28 09:18:19 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/393

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/393
buildbot commented 2021-05-28 21:30:48 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/394

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/394
sarah changed title from WIP: UI Fix Bulk to UI Fix Bulk 2021-05-28 21:35:10 +00:00
buildbot commented 2021-05-28 21:52:38 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/395

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/395
buildbot commented 2021-05-28 22:27:19 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/396

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/396
erinn merged commit acd7fc8259 into trunk 2021-05-28 22:55:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
accessibility

   
android

bugs that are android specific

  
before-launch

   
blocked-on-external-dependency

   
bug

Something is not working

  
chat-overlay

   
document-workaround

   
double-column

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
fix-pending

   
flutter-bug

   
group-experiment

   
help wanted

Need some help

  
invalid

Something is wrong

  
invite-overlay

   
needs-testing

   
packaging

   
privacy

   
provisionally-fixed

   
question

More information is needed

  
theme

   
tor

   
windows

   
wontfix

This won't be fixed

No Label
accessibility
android
before-launch
blocked-on-external-dependency
bug
chat-overlay
document-workaround
double-column
duplicate
enhancement
fix-pending
flutter-bug
group-experiment
help wanted
invalid
invite-overlay
needs-testing
packaging
privacy
provisionally-fixed
question
theme
tor
windows
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
erinn
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: flutter/flutter_app#96
No description provided.
Delete Branch "ui_fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?