flutter
/
flutter_app
6
1
Fork 0
Code Issues 14 Pull Requests Releases 1 Wiki Activity

add buildtime injectable build version and date #98

Merged
sarah merged 1 commits from version into trunk 2021-05-31 18:11:24 +00:00
Conversation 2 Commits 1 Files Changed 4 +19 -3
dan commented 2021-05-29 16:06:40 +00:00
Owner
Copy Link

buildtime injectable date and version. toggle in gomobile and ffi cwtch modules to set profile path accordingly!

buildtime injectable date and version. toggle in gomobile and ffi cwtch modules to set profile path accordingly!
buildbot commented 2021-05-29 16:10:18 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/398

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/398
sarah reviewed 2021-05-31 15:42:30 +00:00
lib/main.dart Outdated
@ -21,0 +24,4 @@
static const BUILD_VER = String.fromEnvironment('BUILD_VER', defaultValue: dev_version);
static const BUILD_DATE = String.fromEnvironment('BUILD_DATE', defaultValue: "now");
}
sarah commented 2021-05-31 15:42:30 +00:00
Owner
Copy Link

I would move this to a config.dart file...just to avoid the weird import loop between gomobile/ffi.dart and main.dart (dart doesn't seem to mind, but it keeps things conceptually cleaner)

I would move this to a config.dart file...just to avoid the weird import loop between gomobile/ffi.dart and main.dart (dart doesn't seem to mind, but it keeps things conceptually cleaner)
buildbot commented 2021-05-31 18:09:34 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/flutter_app/399

Drone Build Status: success https://build.openprivacy.ca/flutter/flutter_app/399
sarah merged commit 1776e73836 into trunk 2021-05-31 18:11:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility

   
android

bugs that are android specific

  
before-launch

   
blocked-on-external-dependency

   
bug

Something is not working

  
chat-overlay

   
document-workaround

   
double-column

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
fix-pending

   
flutter-bug

   
group-experiment

   
help wanted

Need some help

  
invalid

Something is wrong

  
invite-overlay

   
needs-testing

   
packaging

   
privacy

   
provisionally-fixed

   
question

More information is needed

  
theme

   
tor

   
windows

   
wontfix

This won't be fixed

No Label
accessibility
android
before-launch
blocked-on-external-dependency
bug
chat-overlay
document-workaround
double-column
duplicate
enhancement
fix-pending
flutter-bug
group-experiment
help wanted
invalid
invite-overlay
needs-testing
packaging
privacy
provisionally-fixed
question
theme
tor
windows
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: flutter/flutter_app#98
No description provided.
Delete Branch "version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?