flutter
/
flutter_file_picker
5
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixes out of memory issue on some devices when picking big files (#392)

This commit is contained in:
Miguel Ruivo 2020-09-25 18:25:01 +01:00
parent b46422a195
commit f731f4ae26
3 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -1,3 +1,6 @@
## 2.0.3
Android: Fixes out of memory issue on some devices when picking big files.
## 2.0.2+2 ## 2.0.2+2
Fixes multi-pick example on README. Fixes multi-pick example on README.

21
android/src/main/java/com/mr/flutter/plugin/filepicker/FileUtils.java
View File

@ -2,23 +2,19 @@ package com.mr.flutter.plugin.filepicker;
import android.annotation.SuppressLint; import android.annotation.SuppressLint;
import android.annotation.TargetApi; import android.annotation.TargetApi;
import android.content.ContentUris;
import android.content.Context; import android.content.Context;
import android.database.Cursor; import android.database.Cursor;
import android.net.Uri; import android.net.Uri;
import android.os.Build; import android.os.Build;
import android.os.Environment;
import android.os.storage.StorageManager; import android.os.storage.StorageManager;
import android.provider.DocumentsContract; import android.provider.DocumentsContract;
import android.provider.MediaStore;
import android.text.TextUtils;
import android.util.Log; import android.util.Log;
import android.webkit.MimeTypeMap; import android.webkit.MimeTypeMap;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
import java.io.BufferedInputStream; import java.io.BufferedInputStream;
import java.io.ByteArrayOutputStream; import java.io.BufferedOutputStream;
import java.io.File; import java.io.File;
import java.io.FileInputStream; import java.io.FileInputStream;
import java.io.FileNotFoundException; import java.io.FileNotFoundException;
@ -146,7 +142,7 @@ public class FileUtils {
try { try {
fos = new FileOutputStream(path); fos = new FileOutputStream(path);
try { try {
final ByteArrayOutputStream out = new ByteArrayOutputStream(); final BufferedOutputStream out = new BufferedOutputStream(fos);
final InputStream in = context.getContentResolver().openInputStream(uri); final InputStream in = context.getContentResolver().openInputStream(uri);
final byte[] buffer = new byte[8192]; final byte[] buffer = new byte[8192];
@ -157,9 +153,18 @@ public class FileUtils {
} }
if(withData) { if(withData) {
fileInfo.withData(out.toByteArray()); try {
FileInputStream fis = null;
byte[] bytes = new byte[(int) file.length()];
fis = new FileInputStream(file);
fis.read(bytes);
fis.close();
fileInfo.withData(bytes);
} catch (Exception e) {
Log.e(TAG, "Failed to load bytes into memory with error " + e.toString() + ". Probably the file is too big to fit device memory. Bytes won't be added to the file this time.");
}
} }
out.writeTo(fos);
out.flush(); out.flush();
} finally { } finally {
fos.getFD().sync(); fos.getFD().sync();

2
pubspec.yaml
View File

@ -1,7 +1,7 @@
name: file_picker name: file_picker
description: A package that allows you to use a native file explorer to pick single or multiple absolute file paths, with extension filtering support. description: A package that allows you to use a native file explorer to pick single or multiple absolute file paths, with extension filtering support.
homepage: https://github.com/miguelpruivo/plugins_flutter_file_picker homepage: https://github.com/miguelpruivo/plugins_flutter_file_picker
version: 2.0.2+2 version: 2.0.3
dependencies: dependencies:
flutter: flutter: