flutter
/
libcwtch-go
5
0
Fork 0
Code Issues Pull Requests Releases 2 Wiki Activity

Add Contact Flow #18

Merged
dan merged 1 commits from peersettings into trunk 2021-03-29 22:39:36 +00:00
Conversation 0 Commits 1 Files Changed 8 +206 -4
sarah commented 2021-03-24 23:25:36 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2021-03-24 23:25:36 +00:00
sarah changed title from Add Contact Flow to WIP: Add Contact Flow 2021-03-24 23:26:26 +00:00
erinn was assigned by sarah 2021-03-24 23:26:38 +00:00
sarah changed title from WIP: Add Contact Flow to Add Contact Flow 2021-03-25 20:28:17 +00:00
dan reviewed 2021-03-25 23:43:50 +00:00
features/peer/peer_functionality.go Outdated
@ -0,0 +25,4 @@
}
// HandleImportString handles import strings for peers
func (pf *PeerFunctionality) HandleImportString(peer peer.CwtchPeer, importString string) error {
dan commented 2021-03-25 23:41:34 +00:00
Owner
Copy Link

i guess it's still a little weird for me seeing it only return an "error" type but some of those are actually "success" conditions?
not actaull any bug, just weird symantics

i guess it's still a little weird for me seeing it only return an "error" type but some of those are actually "success" conditions? not actaull any bug, just weird symantics
utils/manager.go Outdated
@ -268,3 +269,2 @@
ev.Event.Data["nick"] = ph.GetNick(handle)
ev.Event.Data["status"] = strconv.Itoa(int(connections.ConnectionStateToType()[contact.State]))
// Will be disconnected to start
dan commented 2021-03-25 23:43:43 +00:00
Owner
Copy Link

i don't think that's necesarily true, if its android with client/service, on a resume it'll send out NewPeer events on a resume and they'll having existing status connection states

i don't think that's necesarily true, if its android with client/service, on a resume it'll send out NewPeer events on a resume and they'll having existing status connection states
erinn approved these changes 2021-03-25 23:44:10 +00:00
dan merged commit 3ea5121998 into trunk 2021-03-29 22:39:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
erinn
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
erinn
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: flutter/libcwtch-go#18
No description provided.
Delete Branch "peersettings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?