openprivacy
/
connectivity
3
0
Fork 2
Code Issues 1 Pull Requests 1 Releases 35 Wiki Activity

Fix several small goroutine leaks around restart #29

Merged
sarah merged 1 commits from goroutine-fixes into master 2022-04-18 22:02:20 +00:00
Conversation 2 Commits 1 Files Changed 3 +79 -13
sarah commented 2022-04-18 21:53:08 +00:00
Owner
Copy Link

Also apparently some much older version timeout stuff I forgot about...

Also apparently some much older version timeout stuff I forgot about...
dan was assigned by sarah 2022-04-18 21:53:08 +00:00
buildbot commented 2022-04-18 21:57:04 +00:00
First-time contributor
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/openprivacy/connectivity/111

Drone Build Status: success https://build.openprivacy.ca/openprivacy/connectivity/111
sarah force-pushed goroutine-fixes from 66cf89a480 to 8d0ed17e7f 2022-04-18 21:59:45 +00:00 Compare
dan approved these changes 2022-04-18 21:59:48 +00:00
dan left a comment
Owner
Copy Link

i think we might need a slightly longer than 2 second time out, I feel like i've seen it take a bit on android before? otherwise cool looks good

i think we might need a slightly longer than 2 second time out, I feel like i've seen it take a bit on android before? otherwise cool looks good
buildbot commented 2022-04-18 22:02:05 +00:00
First-time contributor
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/openprivacy/connectivity/113

Drone Build Status: success https://build.openprivacy.ca/openprivacy/connectivity/113
sarah merged commit 0803c09fd3 into master 2022-04-18 22:02:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: openprivacy/connectivity#29
No description provided.
Delete Branch "goroutine-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?