tor reattach to detached onions #44

dan · 2018-12-07T01:50:45Z

dan commented

2018-12-07 01:50:45 +00:00

No description provided.

dan commented

2018-12-07 17:18:50 +00:00

hmmm the integ test is timing out...

buildbot commented

2018-12-07 18:47:08 +00:00

First-time contributor

Drone Build Status: success

https://build.openprivacy.ca/openprivacy/libricochet-go/109

Drone Build Status: success https://build.openprivacy.ca/openprivacy/libricochet-go/109

sarah commented

2018-12-12 20:36:45 +00:00

Why:

bineed255192 "github.com/cretz/bine/torutil/ed25519"

We are already relying on 2 ed25519 libraries + our own in util/crypto. I'd really rather not have to deal with another ed25519 util package. Can we do what this is doing without this?

Why: bineed255192 "github.com/cretz/bine/torutil/ed25519" We are already relying on 2 ed25519 libraries + our own in util/crypto. I'd really rather not have to deal with another ed25519 util package. Can we do what this is doing without this?

dan commented

2018-12-13 18:58:18 +00:00

All it's being used for is bineed255192.FromCryptoPrivateKey(privkey) which is putting the private key in the format bine needs, because everyone uses theri own lib format

All it's being used for is `bineed255192.FromCryptoPrivateKey(privkey)` which is putting the private key in the format bine needs, because everyone uses theri own lib format

sarah commented

2018-12-14 18:28:44 +00:00

Urgh looks like Bine has an entire ed25519 implementation to get around the key format issues between golang and Tor. I really dislike that. There are already 2 versions of ScalarMult compiled in libricochet, this would be a 3rd. We should consider the impact of having to audit this code down the line.

(Also, at some point we will likely be incorporating https://github.com/bwesterb/go-ristretto somewhere in this stack also which will be a 4th, but at least that one provides extra functionality).

I'm going to let Erinn review this code, and won't block merging it but I think we need to push back on bine & extra25519 having their own implementation.

Urgh looks like Bine has an entire ed25519 implementation to get around the key format issues between golang and Tor. I really dislike that. There are already 2 versions of ScalarMult compiled in libricochet, this would be a 3rd. We should consider the impact of having to audit this code down the line. (Also, at some point we will likely be incorporating https://github.com/bwesterb/go-ristretto somewhere in this stack also which will be a 4th, but at least that one provides extra functionality). I'm going to let Erinn review this code, and won't block merging it but I think we need to push back on bine & extra25519 having their own implementation.

erinn closed this pull request

2018-12-18 19:49:29 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers