openprivacy
/
libricochet-go
Archived
4
3
Fork 2
Code Issues 2 Pull Requests Releases 14 Wiki Activity

Fixing Linting, Vetting & Formatting Issues (Fix #8) #47

Merged
dan merged 1 commits from cleanup into master 2019-01-11 20:01:07 +00:00
Conversation 7 Commits 1 Files Changed 18 +55 -29
sarah commented 2019-01-09 22:36:33 +00:00
Owner
Copy Link

This commit brings the code mostly up to standard and resolves #8. Added a few explicit TODOs in the code that earmark planned deprecation, made allowances for autogenerated code.

This commit brings the code mostly up to standard and resolves #8. Added a few explicit TODOs in the code that earmark planned deprecation, made allowances for autogenerated code.
buildbot commented 2019-01-09 22:40:32 +00:00
First-time contributor
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/openprivacy/libricochet-go/117

Drone Build Status: success https://build.openprivacy.ca/openprivacy/libricochet-go/117
dan commented 2019-01-09 22:55:46 +00:00
Owner
Copy Link

if it fixes it, edit the .drone.yml file and enable strict golint by adding -set_exit_status as an arg to golinton line 19

if it fixes it, edit the .drone.yml file and enable strict golint by adding -set_exit_status as an arg to golinton line 19
buildbot commented 2019-01-09 23:03:08 +00:00
First-time contributor
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/openprivacy/libricochet-go/119

Drone Build Status: success https://build.openprivacy.ca/openprivacy/libricochet-go/119
sarah commented 2019-01-09 23:05:41 +00:00
Author
Owner
Copy Link

Done, See https://build.openprivacy.ca/openprivacy/libricochet-go/120/4

Done, See https://build.openprivacy.ca/openprivacy/libricochet-go/120/4
buildbot commented 2019-01-09 23:08:12 +00:00
First-time contributor
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/openprivacy/libricochet-go/121

Drone Build Status: success https://build.openprivacy.ca/openprivacy/libricochet-go/121
dan commented 2019-01-11 18:11:56 +00:00
Owner
Copy Link

application should pass

I agree, ignoring application/examples, examples and wire should be fine.

i think application only needs 2 things

application should pass I agree, ignoring application/examples, examples and wire should be fine. i think application only needs 2 things
sarah commented 2019-01-11 18:41:18 +00:00
Author
Owner
Copy Link

Changing application requires follow up changes in Cwtch, and other downstreams that directly instantiate ApplicationInstance. That's going to require a 3-part change to do nicely which I think makes sens to do separately.

Changing application requires follow up changes in Cwtch, and other downstreams that directly instantiate ApplicationInstance. That's going to require a 3-part change to do nicely which I think makes sens to do separately.
dan closed this pull request 2019-01-11 20:01:06 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
dan
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: openprivacy/libricochet-go#47
No description provided.
Delete Branch "cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?