openprivacy
/
libricochet-go
Archived
4
3
Fork 2
Code Issues 2 Pull Requests Releases 14 Wiki Activity

Fix #4 By Adding an Explicit Close() Method to Connection #49

Merged
dan merged 1 commits from close into master 2019-01-21 20:30:21 +00:00
Conversation 6 Commits 1 Files Changed 5 +40 -18
sarah commented 2019-01-11 20:32:33 +00:00
Owner
Copy Link
No description provided.
buildbot commented 2019-01-11 20:39:03 +00:00
First-time contributor
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/openprivacy/libricochet-go/124

Drone Build Status: success https://build.openprivacy.ca/openprivacy/libricochet-go/124
dan commented 2019-01-14 19:54:55 +00:00
Owner
Copy Link

application/Shutdown() should be updated to use this

then

does Connection and Connection.Conn need to be public?

application/Shutdown() should be updated to use this then does Connection and Connection.Conn need to be public?
sarah commented 2019-01-15 19:40:51 +00:00
Author
Owner
Copy Link

Updated Shutdown and made Conn not-public (yay!)

Updated Shutdown and made Conn not-public (yay!)
buildbot commented 2019-01-15 19:45:36 +00:00
First-time contributor
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/openprivacy/libricochet-go/133

Drone Build Status: success https://build.openprivacy.ca/openprivacy/libricochet-go/133
sarah commented 2019-01-21 19:20:55 +00:00
Author
Owner
Copy Link

Also fixes #5 now.

Also fixes #5 now.
buildbot commented 2019-01-21 19:25:07 +00:00
First-time contributor
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/openprivacy/libricochet-go/135

Drone Build Status: success https://build.openprivacy.ca/openprivacy/libricochet-go/135
dan closed this pull request 2019-01-21 20:30:21 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
dan
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: openprivacy/libricochet-go#49
No description provided.
Delete Branch "close"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?