openprivacy
/
zcashrpc
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Clean up APIs #2

Manually merged
dan merged 1 commits from cleanup into master 2019-12-02 20:18:13 +00:00
Conversation 0 Commits 1 Files Changed 13 +290 -257
sarah commented 2019-12-02 19:40:31 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2019-12-02 19:40:31 +00:00
dan reviewed 2019-12-02 20:13:20 +00:00
dan left a comment
Owner
Copy Link

Do we want a .Close() for ZcashClient?

Do we want a .Close() for ZcashClient?
api.go
@ -0,0 +29,4 @@
}
// NewGetTransaction constructs a properly formatted gettransaction request
func NewGetTransaction(is string) []byte {
dan commented 2019-12-02 19:58:32 +00:00
Owner
Copy Link

these 3 functions seems a bit repetitive 🤷 nbd

these 3 functions seems a bit repetitive :shrug: nbd
dan closed this pull request 2019-12-02 20:18:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: openprivacy/zcashrpc#2
No description provided.
Delete Branch "cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?