Options approach for creating new CwtchBot #2

decentral1se · 2023-06-11T22:19:16Z

decentral1se commented

2023-06-11 22:19:16 +00:00

First-time contributor

Maybe nice to unify the same New... signature with this typical options approach.

NewCwtchBot("foo", "bar")
NewCwtchBotWithExperiments("foo", "bar", []string{"baz"})

👇

NewCwtchBot("foo", "bar", WithExperiments([]string{"baz"}))

🎺 This is a breaking change 🎺

Maybe nice to unify the same `New...` signature with this typical options approach. ```go NewCwtchBot("foo", "bar") NewCwtchBotWithExperiments("foo", "bar", []string{"baz"}) ``` 👇 ```go NewCwtchBot("foo", "bar", WithExperiments([]string{"baz"})) ``` 🎺 This is a breaking change 🎺

decentral1se added 2 commits 2023-06-11 22:19:17 +00:00

bd0ad9c98c

chore: remove whitespace

804e6e8d9b

chore: gofmt import sort

decentral1se force-pushed options-refactor from 1be0c9aa8f to 9fedfb83b0

2023-06-11 22:24:03 +00:00

Compare

sarah approved these changes 2023-06-16 21:10:18 +00:00

sarah commented

2023-06-16 21:11:12 +00:00

Thanks, this looks like a good change. Will merge this in when I do a CwtchBot pass in a couple of weeks (since this will require a fuzzbot update).

sarah commented

2023-06-16 21:11:40 +00:00

Actually https://git.openprivacy.ca/sarah/cwtchbot/src/branch/main/cmd/echobot/main.go will also need to be updated.

decentral1se commented

2023-06-20 07:19:51 +00:00

First-time contributor

Cool, thanks for the review! Unsure where echobot needs updating due to it only using NewCwtchBot and not accepting experiment args? Was curious to take a stab at the fuzzbot code but can't seem to find it online here? Down to help on updates anyway, lemme know if that's handy.

Cool, thanks for the review! Unsure where `echobot` needs updating due to it only using `NewCwtchBot` and not accepting experiment args? Was curious to take a stab at the `fuzzbot` code but can't seem to find it online here? Down to help on updates anyway, lemme know if that's handy.

decentral1se referenced this pull request from cwtch.im/cwtch

2023-07-21 12:50:27 +00:00

API surface for initialisng application? #523

This pull request can be merged automatically.

You are not authorized to merge this pull request.

You can also view command line instructions.