image previews #267
No reviewers
Labels
No Label
android
arch
backlog
blocked-on-external
bug
bugbash
component/bindings
component/bine
component/connectivity
component/cwtch
component/tapir
component/ui
cwtch-1.14
cwtch-1.15
cwtch-beta-1.1
cwtch-beta-1.10
cwtch-beta-1.11
cwtch-beta-1.12
cwtch-beta-1.13
cwtch-beta-1.2
cwtch-beta-1.3
cwtch-beta-1.4
cwtch-beta-1.5
cwtch-beta-1.5.x
cwtch-beta-1.6
cwtch-beta-1.7
cwtch-beta-1.8
cwtch-beta-1.9
design
duplicate
enhancement
flutter
funding-needed
help wanted
hybrid-groups
in-nightly
in-progress
invalid
ios
linux
mac
need-replication-or-investigation
ops
packaging
post-stable
question
questionable
requires-more-effort-than-we-can-spare
rust
scheduled
stable-blocker
tails
testing-needed
tests
tor
waiting-on-fix-confirmation
waiting-on-new-flutter-feature
whonix
windows
wontfix
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/cwtch-ui#267
Loading…
Reference in New Issue
No description provided.
Delete Branch "ipreview"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
this PR will need a changepassword libcwtch PR to verify/merged first
Soooo for 1.6 I think we need to start tabbing global settings with options and experiments tabs?
@ -18,1 +18,3 @@
void DeleteProfile(String onion, String pass);
void DeleteProfile(String profile, String pass);
// ignore: non_constant_identifier_names
void ChangePassword(String profile, String pass, String newpass, String newpassAgain);
lol changePassword got rolled into this?
@ -55,6 +57,8 @@ abstract class Cwtch {
void CheckDownloadStatus(String profile, String fileKey);
// ignore: non_constant_identifier_names
void VerifyOrResumeDownload(String profile, int handle, String filekey);
// ignore: non_constant_identifier_names
comment here possibly as well that this is android only functionality?
@ -223,3 +225,3 @@
break;
case "SendMessageToPeerError":
// Ignore
// Ignore dealt with by IndexedFailure
confirm? I don't see IndexedFailure being issued in Cwtch or libcwtch-go, they still appear to issue SendMessageToPeerError and SendMessageToGroupError
@ -695,1 +700,4 @@
@override
String defaultDownloadPath() {
Map<String, String> envVars = Platform.environment;
return path.join(envVars['HOME']!, "Downloads");
check above in L134 in Start. MacOS and Linux should be good but we need something like
if (Platform.isWindows) { path.join(envVars['UserProfile']!, "Downloads"); }
@ -404,3 +401,2 @@
} else {
print("error: received progress for unknown download " + fileKey);
}
notifyListeners();
could put one single notifyListeners at the bottom? as its at the end of the if and else?
@ -65,1 +66,4 @@
}
}
} catch (e) {
// provider check failed...make an expensive call...
still TODO?
nope it is a fall through
@ -279,3 +281,3 @@
}
void _createPressed() {
void _createPressed() async {
do we need a Provider.of(context, listen: false).reset(); something like here?
@ -315,0 +317,4 @@
if (AppLocalizations.of(context) != null) {
final snackBar = SnackBar(content: Text(AppLocalizations.of(context)!.passwordChangeError));
ScaffoldMessenger.of(context).showSnackBar(snackBar);
Navigator.pop(context);
why do we pop the nav on error? shouldn't we stay on this pane?
@ -315,0 +326,4 @@
final snackBar = SnackBar(content: Text(AppLocalizations.of(context)!.newPassword));
ScaffoldMessenger.of(context).showSnackBar(snackBar);
Navigator.pop(context);
return; // otherwise round and round we go...
dont understand the comment?
@ -388,2 +391,2 @@
print("file size cannot exceed 10 gigabytes");
//todo: toast error
final snackBar = SnackBar(
content: Text("File size cannot exceed 10 GB"),
translate
@ -393,0 +418,4 @@
mainAxisAlignment: MainAxisAlignment.center,
mainAxisSize: MainAxisSize.min,
children: <Widget>[
Text("Are you sure you want to send $path?"),
translate
@ -393,0 +444,4 @@
),
SizedBox(width: 20,),
ElevatedButton(
child: Text("Send File", semanticsLabel: "Send File"),
tranalte
@ -49,0 +61,4 @@
var path = Provider.of<ProfileInfoState>(context).downloadFinalPath(widget.fileKey());
if (downloadComplete) {
var lpath = path!.toLowerCase();
if (lpath.endsWith("jpg") || lpath.endsWith("jpeg") || lpath.endsWith("png") || lpath.endsWith("gif") || lpath.endsWith("webp") || lpath.endsWith("bmp")) {
i've seen this check in a few places, prolly make into a utility function
@ -96,0 +116,4 @@
padding: EdgeInsets.all(1.0),
child: Image.file(
myFile!,
cacheWidth: 2048, // limit the amount of space the image can decode too, we keep this high-ish to allow quality previews...
this still seems higher than we'll likely display? 1080p screens in full screen single pane mode will stil be too narrow even ignoring padding?
@ -96,0 +161,4 @@
]));
}
} else if (!senderIsContact) {
wdgDecorations = Text("Add this account to your contacts in order to accept this file.");
translate
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch-ui/409
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch-ui/410
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/412
wip: image previewsto image previews