cwtch.im
/
libcwtch-go
Archived
3
0
Fork 1
Code Issues 2 Pull Requests Releases 26 Wiki Activity

image previews #51

Merged
sarah merged 7 commits from ipreview into trunk 2021-12-19 01:21:40 +00:00
Conversation 0 Commits 7 Files Changed 5 +54 -10
erinn commented 2021-12-17 00:51:07 +00:00
Owner
Copy Link
* depends on https://git.openprivacy.ca/cwtch.im/cwtch/pulls/413
erinn added 4 commits 2021-12-17 00:51:08 +00:00
continuous-integration/drone/pr Build is pending Details
eb33f11127 message previews - remove debug
sarah approved these changes 2021-12-17 19:55:28 +00:00
utils/eventHandler.go Outdated
@ -269,0 +281,4 @@
if fm.ShouldAutoDL() {
settings := ReadGlobalSettings()
basepath := settings.DownloadPath
fp, mp := filesharing.GenerateDownloadPath(basepath, fm.Name)
sarah commented 2021-12-17 19:55:15 +00:00
Owner

These two paths (for NewMessageFromPeer and NewMessageFromGroup) are very similar any way to combine them?

These two paths (for NewMessageFromPeer and NewMessageFromGroup) are very similar any way to combine them?
dan commented 2021-12-18 17:55:27 +00:00
Owner

pull out and make a function?

pull out and make a function?
utils/eventHandler.go Outdated
@ -283,2 +308,4 @@
conversationID, _ := strconv.Atoi(ev.Event.Data[event.ConversationID])
profile.SetConversationAttribute(conversationID, attr.LocalScope.ConstructScopedZonedPath(attr.ProfileZone.ConstructZonedPath(constants2.Archived)), event.False)
// note careful use of ci.ID versus conversationID
sarah commented 2021-12-17 19:53:30 +00:00
Owner

expand comment to explain this is because we download from the contact not the group we received the message on (for now at least).

expand comment to explain this is because we download from the contact not the group we received the message on (for now at least).
erinn marked this conversation as resolved
utils/eventHandler.go Outdated
@ -285,0 +322,4 @@
basepath := settings.DownloadPath
fp, mp := filesharing.GenerateDownloadPath(basepath, fm.Name)
log.Debugf("autodownloading file!")
ev.Event.Data["Auto"] = "true"
sarah commented 2021-12-17 19:53:54 +00:00
Owner

use contants.True

use `contants.True`
erinn marked this conversation as resolved
utils/eventHandler.go Outdated
@ -285,0 +324,4 @@
log.Debugf("autodownloading file!")
ev.Event.Data["Auto"] = "true"
mID, _ := strconv.Atoi(ev.Event.Data["Index"])
profile.UpdateMessageAttribute(conversationID, 0, mID, "file-downloaded", "true")
sarah commented 2021-12-17 19:54:27 +00:00
Owner

file-downloaded should probably be in constants, use constants.True

file-downloaded should probably be in `constants`, use `constants.True`
erinn marked this conversation as resolved
dan reviewed 2021-12-18 17:57:41 +00:00
utils/eventHandler.go Outdated
@ -282,6 +307,29 @@ func (eh *EventHandler) handleProfileEvent(ev *EventProfileEnvelope) string {
ev.Event.Data["Picture"] = RandomProfileImage(ev.Event.Data[event.RemotePeer])
conversationID, _ := strconv.Atoi(ev.Event.Data[event.ConversationID])
profile.SetConversationAttribute(conversationID, attr.LocalScope.ConstructScopedZonedPath(attr.ProfileZone.ConstructZonedPath(constants2.Archived)), event.False)
dan commented 2021-12-18 17:57:41 +00:00
Owner

not actaully in this PR but @sarah why are we setting this attribute on each message from group?

not actaully in this PR but @sarah why are we setting this attribute on each message from group?
erinn added 2 commits 2021-12-19 01:16:39 +00:00
continuous-integration/drone/pr Build is pending Details
f4ff802460 image previews sarah comments
erinn added 1 commit 2021-12-19 01:20:15 +00:00
continuous-integration/drone/pr Build is pending Details
11bbc3aa78 bump cwtch and fix miscommits
erinn changed title from wip: image previews to image previews 2021-12-19 01:20:42 +00:00
sarah merged commit e4244aeb31 into trunk 2021-12-19 01:21:40 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
sarah
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/libcwtch-go#51
No description provided.
Delete Branch "ipreview"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?