cwtch.im
/
cwtch-ui
10
11
Fork 17
Code Issues 89 Pull Requests 2 Projects 2 Releases 28 Wiki Activity

Implement Quoting #96

Merged
dan merged 7 commits from quote into trunk 2021-07-07 18:46:28 +00:00
Conversation 5 Commits 7 Files Changed 28 +854 -400
sarah commented 2021-07-06 19:51:44 +00:00
Owner
Copy Link

This PR also contains a complete refactor of Messagfes in the UI to reduce duplication when dealing with message, fix a few bugs relating to update message metadata and to make it more compliant with Flutters Future API.

This PR also contains a complete refactor of Messagfes in the UI to reduce duplication when dealing with message, fix a few bugs relating to update message metadata and to make it more compliant with Flutters Future API.
dan was assigned by sarah 2021-07-06 19:51:44 +00:00
erinn was assigned by sarah 2021-07-06 19:51:44 +00:00
dan reviewed 2021-07-06 20:37:32 +00:00
dan left a comment
Owner
Copy Link

also I asked general questions about moving the location of the hashed look up from cwtch to any level higher in chat

also I asked general questions about moving the location of the hashed look up from cwtch to any level higher in chat
lib/models/message.dart Outdated
@ -0,0 +20,4 @@
return rawMessageEnvelopeFuture.then((dynamic rawMessageEnvelope) {
dynamic messageWrapper = jsonDecode(rawMessageEnvelope);
if (messageWrapper['Message'] == null || messageWrapper['Message'] == '' || messageWrapper['Message'] == '{}') {
return Future.delayed(Duration(seconds: 2), () {
dan commented 2021-07-06 20:05:51 +00:00
Owner
Copy Link

why a 2 second delate to get a messageHandler?

why a 2 second delate to get a messageHandler?
sarah commented 2021-07-06 20:47:56 +00:00
Author
Owner
Copy Link

Because there is a chance that the index hasn't been added to the timeline yet (because we don't wait until we confirm the message has been added to the timeline before we increment the number of messages in the timeline (e.g. when sending a message))

Because there is a chance that the index hasn't been added to the timeline yet (because we don't wait until we confirm the message has been added to the timeline before we increment the number of messages in the timeline (e.g. when sending a message))
dan commented 2021-07-06 21:30:12 +00:00
Owner
Copy Link

is there ever a case that it wont get added? cus this is recursion with no end state for an error

is there ever a case that it wont get added? cus this is recursion with no end state for an error
sarah commented 2021-07-07 17:07:46 +00:00
Author
Owner
Copy Link

Added comments on this method to explain why this should mostyly never happen.

Added comments on this method to explain why this should mostyly never happen.
lib/models/message.dart Outdated
@ -0,0 +46,4 @@
var metadata = MessageMetadata(profileOnion, contactHandle, index, timestamp, senderHandle, senderImage, signature, flags, ackd, error);
switch (overlay) {
case 1:
dan commented 2021-07-06 20:07:09 +00:00
Owner
Copy Link

we prolly want to capture these as defined consts somewhere?

we prolly want to capture these as defined consts somewhere?
sarah marked this conversation as resolved
lib/models/messages/invitemessage.dart Outdated
@ -0,0 +27,4 @@
String inviteTarget;
String inviteNick;
if (this.content.length == 56) {
dan commented 2021-07-06 20:33:56 +00:00
Owner
Copy Link

define const or make isGroup()

define const or make isGroup()
sarah marked this conversation as resolved
buildbot commented 2021-07-06 22:18:31 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch-ui/74

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch-ui/74
sarah force-pushed quote from 5e8c700ce7 to 5d1fa05079 2021-07-07 17:05:49 +00:00 Compare
sarah changed title from WIP: Implement Quoting to Implement Quoting 2021-07-07 17:06:03 +00:00
buildbot commented 2021-07-07 17:11:08 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch-ui/83

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch-ui/83
sarah force-pushed quote from 5d1fa05079 to e4046fb574 2021-07-07 18:11:17 +00:00 Compare
buildbot commented 2021-07-07 18:18:42 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/84

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/84
sarah added 1 commit 2021-07-07 18:25:21 +00:00
continuous-integration/drone/pr Build is passing Details
1c460b431e Remove print + add check for body in quote
dan approved these changes 2021-07-07 18:28:52 +00:00
lib/models/message.dart
@ -0,0 +55,4 @@
var error = messageWrapper['Error'] != null;
String? signature;
// If this is a group, store the signature
if (contactHandle.length == 32) {
dan commented 2021-07-07 18:28:00 +00:00
Owner
Copy Link

const

const
sarah added 1 commit 2021-07-07 18:31:26 +00:00
continuous-integration/drone/pr Build is passing Details
0c9da27363 const group handle length
buildbot commented 2021-07-07 18:44:51 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/86

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/86
dan merged commit 84a0ca5d19 into trunk 2021-07-07 18:46:28 +00:00
buildbot commented 2021-07-07 18:49:33 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/85

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/85
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
android

   
arch

   
backlog

   
blocked-on-external

This issue requires effort from an external organization to move forward

  
bug

Something is not working

  
bugbash

   
component/bindings

   
component/bine

   
component/connectivity

   
component/cwtch

   
component/tapir

   
component/ui

   
cwtch-1.14

   
cwtch-1.15

   
cwtch-beta-1.1

   
cwtch-beta-1.10

Changes Planned for Cwtch Beta 1.10

  
cwtch-beta-1.11

   
cwtch-beta-1.12

   
cwtch-beta-1.13

   
cwtch-beta-1.2

   
cwtch-beta-1.3

   
cwtch-beta-1.4

   
cwtch-beta-1.5

   
cwtch-beta-1.5.x

point release vug fixes for 1.5

  
cwtch-beta-1.6

   
cwtch-beta-1.7

   
cwtch-beta-1.8

   
cwtch-beta-1.9

   
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
flutter

   
funding-needed

   
help wanted

Need some help

  
hybrid-groups

   
in-nightly

   
in-progress

   
invalid

Something is wrong

  
ios

   
linux

   
mac

   
need-replication-or-investigation

   
ops

   
packaging

   
post-stable

These issues won't be considered until after Cwtch Stable ships.

  
question

More information is needed

  
questionable

there is an open question as to whether this is an issue at all / if we can even fix this

  
requires-more-effort-than-we-can-spare

The amount of work involved to solve this issue would occupy our entire development team for a significant period of time and/or provide little benefit to the rest of the project

  
rust

   
scheduled

   
stable-blocker

   
tails

   
testing-needed

   
tests

   
tor

   
waiting-on-fix-confirmation

   
waiting-on-new-flutter-feature

The cause of this issue is a bug in the underlying flutter framework.

  
whonix

   
windows

   
wontfix

This won't be fixed

No Label
android
arch
backlog
blocked-on-external
bug
bugbash
component/bindings
component/bine
component/connectivity
component/cwtch
component/tapir
component/ui
cwtch-1.14
cwtch-1.15
cwtch-beta-1.1
cwtch-beta-1.10
cwtch-beta-1.11
cwtch-beta-1.12
cwtch-beta-1.13
cwtch-beta-1.2
cwtch-beta-1.3
cwtch-beta-1.4
cwtch-beta-1.5
cwtch-beta-1.5.x
cwtch-beta-1.6
cwtch-beta-1.7
cwtch-beta-1.8
cwtch-beta-1.9
design
duplicate
enhancement
flutter
funding-needed
help wanted
hybrid-groups
in-nightly
in-progress
invalid
ios
linux
mac
need-replication-or-investigation
ops
packaging
post-stable
question
questionable
requires-more-effort-than-we-can-spare
rust
scheduled
stable-blocker
tails
testing-needed
tests
tor
waiting-on-fix-confirmation
waiting-on-new-flutter-feature
whonix
windows
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dan
erinn
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#96
No description provided.
Delete Branch "quote"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?