Implement Quoting #96
No reviewers
Labels
No Label
android
arch
backlog
blocked-on-external
bug
bugbash
component/bindings
component/bine
component/connectivity
component/cwtch
component/tapir
component/ui
cwtch-1.14
cwtch-1.15
cwtch-beta-1.1
cwtch-beta-1.10
cwtch-beta-1.11
cwtch-beta-1.12
cwtch-beta-1.13
cwtch-beta-1.2
cwtch-beta-1.3
cwtch-beta-1.4
cwtch-beta-1.5
cwtch-beta-1.5.x
cwtch-beta-1.6
cwtch-beta-1.7
cwtch-beta-1.8
cwtch-beta-1.9
design
duplicate
enhancement
flutter
funding-needed
help wanted
hybrid-groups
in-nightly
in-progress
invalid
ios
linux
mac
need-replication-or-investigation
ops
packaging
post-stable
question
questionable
requires-more-effort-than-we-can-spare
rust
scheduled
stable-blocker
tails
testing-needed
tests
tor
waiting-on-fix-confirmation
waiting-on-new-flutter-feature
whonix
windows
wontfix
No Milestone
No project
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/cwtch-ui#96
Loading…
Reference in New Issue
No description provided.
Delete Branch "quote"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR also contains a complete refactor of Messagfes in the UI to reduce duplication when dealing with message, fix a few bugs relating to update message metadata and to make it more compliant with Flutters Future API.
also I asked general questions about moving the location of the hashed look up from cwtch to any level higher in chat
@ -0,0 +20,4 @@
return rawMessageEnvelopeFuture.then((dynamic rawMessageEnvelope) {
dynamic messageWrapper = jsonDecode(rawMessageEnvelope);
if (messageWrapper['Message'] == null || messageWrapper['Message'] == '' || messageWrapper['Message'] == '{}') {
return Future.delayed(Duration(seconds: 2), () {
why a 2 second delate to get a messageHandler?
Because there is a chance that the index hasn't been added to the timeline yet (because we don't wait until we confirm the message has been added to the timeline before we increment the number of messages in the timeline (e.g. when sending a message))
is there ever a case that it wont get added? cus this is recursion with no end state for an error
Added comments on this method to explain why this should mostyly never happen.
@ -0,0 +46,4 @@
var metadata = MessageMetadata(profileOnion, contactHandle, index, timestamp, senderHandle, senderImage, signature, flags, ackd, error);
switch (overlay) {
case 1:
we prolly want to capture these as defined consts somewhere?
@ -0,0 +27,4 @@
String inviteTarget;
String inviteNick;
if (this.content.length == 56) {
define const or make isGroup()
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch-ui/74
5e8c700ce7
to5d1fa05079
WIP: Implement Quotingto Implement QuotingDrone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch-ui/83
5d1fa05079
toe4046fb574
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/84
@ -0,0 +55,4 @@
var error = messageWrapper['Error'] != null;
String? signature;
// If this is a group, store the signature
if (contactHandle.length == 32) {
const
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/86
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/85