filesharing #188

Merged
sarah merged 12 commits from filesharing into trunk 2021-09-30 20:39:47 +00:00
Owner
No description provided.
dan was assigned by erinn 2021-09-30 00:21:10 +00:00
sarah was assigned by erinn 2021-09-30 00:21:10 +00:00
erinn added 7 commits 2021-09-30 00:21:11 +00:00
erinn added this to the Cwtch Beta 1.3 project 2021-09-30 00:21:16 +00:00
erinn added 1 commit 2021-09-30 00:21:29 +00:00
continuous-integration/drone/pr Build is running Details
d8453bc530
Merge branch 'trunk' into filesharing
Member
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch-ui/250
sarah added 1 commit 2021-09-30 00:29:25 +00:00
continuous-integration/drone/pr Build is failing Details
bf31a2b062
Filesharing UI Updates
dan approved these changes 2021-09-30 02:15:03 +00:00
@ -354,0 +375,4 @@
FilePickerResult? result = await FilePicker.platform.pickFiles();
if (result != null) {
File file = File(result.files.first.path);
if (file.lengthSync() <= 10737418240) {
Owner

magic number? comment at pls

magic number? comment at pls
sarah marked this conversation as resolved
@ -0,0 +58,4 @@
}
var wdgSender = Center(
widthFactor: 1,
Owner

i know not now but this is an example of us manually setting a font so whem ppl say we dont respect font scaling on high def, this is what they mean :)

i think 1.4 should including font handing in the theme object so it can apply scaling

i know not now but this is an example of us manually setting a font so whem ppl say we dont respect font scaling on high def, this is what they mean :) i think 1.4 should including font handing in the theme object so it can apply scaling
sarah marked this conversation as resolved
@ -0,0 +211,4 @@
style: TextStyle(
color: Provider.of<Settings>(context).theme.messageFromMeTextColor(),
fontSize: 10,
fontFamily: "monospace",
Owner

commennt invite => file

commennt invite => file
sarah marked this conversation as resolved
@ -164,3 +164,3 @@
onHover: (event) {
setState(() {
Provider.of<AppState>(context, listen: false).hoveredIndex = Provider.of<MessageMetadata>(context).messageIndex;
Provider.of<AppState>(context, listen: false).hoveredIndex = Provider.of<MessageMetadata>(context, listen: false).messageIndex;
Owner

random Q: wouldnt we want to listen on AppState.hoveredIndex for change to hlight differently?

random Q: wouldnt we want to listen on AppState.hoveredIndex for change to hlight differently?
Owner

Answer from Erinn: This is inside a setState so will force a rebuild anyway. As such having a listen here will cause a warning.

Answer from Erinn: This is inside a setState so will force a rebuild anyway. As such having a listen here will cause a warning.
sarah marked this conversation as resolved
sarah added 2 commits 2021-09-30 17:53:53 +00:00
sarah changed title from WIP: filesharing to filesharing 2021-09-30 17:54:29 +00:00
sarah added 1 commit 2021-09-30 20:30:08 +00:00
continuous-integration/drone/pr Build is passing Details
9556150c05
Upgrade libCwtch-go + Fix Model merge issue
Member
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/254
sarah merged commit 0c81b4f9d0 into trunk 2021-09-30 20:39:47 +00:00
Sign in to join this conversation.
No reviewers
dan
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#188
No description provided.