Allow Tor Caching + Our Own Linkify #316
No reviewers
Labels
No Label
android
arch
backlog
blocked-on-external
bug
bugbash
component/bindings
component/bine
component/connectivity
component/cwtch
component/tapir
component/ui
cwtch-1.14
cwtch-1.15
cwtch-beta-1.1
cwtch-beta-1.10
cwtch-beta-1.11
cwtch-beta-1.12
cwtch-beta-1.13
cwtch-beta-1.2
cwtch-beta-1.3
cwtch-beta-1.4
cwtch-beta-1.5
cwtch-beta-1.5.x
cwtch-beta-1.6
cwtch-beta-1.7
cwtch-beta-1.8
cwtch-beta-1.9
design
duplicate
enhancement
flutter
funding-needed
help wanted
hybrid-groups
in-nightly
in-progress
invalid
ios
linux
mac
need-replication-or-investigation
ops
packaging
post-stable
question
questionable
requires-more-effort-than-we-can-spare
rust
scheduled
stable-blocker
tails
testing-needed
tests
tor
waiting-on-fix-confirmation
waiting-on-new-flutter-feature
whonix
windows
wontfix
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/cwtch-ui#316
Loading…
Reference in New Issue
No description provided.
Delete Branch "torcache"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
WIP: Allow Tor Caching + Our Own Linkifyto Allow Tor Caching + Our Own LinkifyDrone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/473
ultimately i'm not sure what this is supposed to do or why it's better... if the goal is just "don't change the user's text" then the whole
match.group(2)
parsing section can just be replaced withlist.add(TextElement(match.group(2)!));
@ -0,0 +1,380 @@
//
// Code Originally taken from https://github.com/Cretezy/flutter_linkify/ and
add current git commit to this link
@ -0,0 +1,380 @@
//
// Code Originally taken from https://github.com/Cretezy/flutter_linkify/ and
// subsequently modified...
you told me this wasn't modified
@ -0,0 +2,4 @@
// Code Originally taken from https://github.com/Cretezy/flutter_linkify/ and
// subsequently modified...
// Original License for this code:
// MIT License
needs to be added to
licenses.dart
@ -0,0 +1,128 @@
// Originally from linkify
needs a link with git commit
@ -0,0 +1,128 @@
// Originally from linkify
// MIT License
also needs to be added to
licenses.dart
@ -0,0 +1,127 @@
// Originally from linkify
needs a link (with git commit) and a "was modified". inline comments should also probably call out which changes are from us
@ -0,0 +74,4 @@
var url = originalUrl;
// We do not, ever, change the original text of a message.
code disagrees with the comment
@ -0,0 +76,4 @@
// We do not, ever, change the original text of a message.
if (options.defaultToHttps) {
url = url.replaceFirst('http://', 'https://');
why remove
if (!originalUrl.startsWith...
? this breaks URIs like eghttps://example.com/http://
. also doesn't make sense to me to change explicithttp://
tohttps://
if the user is the one that originally wrote it@ -0,0 +82,4 @@
// These options are intended for the human-readable portion of
// the URI
if (options.humanize) {
originalUrl = originalUrl.replaceFirst(RegExp(r'https?://'), '');
changing the text but not changing the underlying URL?
@ -0,0 +86,4 @@
}
if (options.removeWww) {
originalUrl = originalUrl.replaceFirst(RegExp(r'www\.'), '');
same but worse. link shown to the user could now go to a different place than the underlying URL. also breaks
https://example.com/www.html
@ -3,1 +3,4 @@
import 'package:cwtch/models/message.dart';
import 'package:cwtch/third_party/linkify/flutter_linkify.dart';
import 'package:cwtch/third_party/linkify/linkify.dart';
import 'package:cwtch/third_party/linkify/uri.dart';
can't these be combined into one import?
approved with sadness
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/477