69 nice theme fixes #590

Merged

sarah merged 4 commits from 69nicefixes into trunk

2022-12-06 00:33:23 +00:00

erinn commented

2022-12-06 00:27:46 +00:00

Owner

@marcia did a theme review in CWTCH_COLOUR_THEMES_FIXES_OCT_2022.xlsx on cloud. This PR addresses everything except:

(48) resizing the mobile splash, which I left as a comment on #580
(3) add titles like "Today", "Last Week", "..." to Manage Files list which I've filed as #589 (I did reverse the chronological order, however)

Attached file has the full list of fixes, along with my notes on implementing them.

ScaffoldMessenger GlobalKey change is to fix (2) duplicate "Copied to clipboard" popup.

@marcia did a theme review in CWTCH_COLOUR_THEMES_FIXES_OCT_2022.xlsx on cloud. This PR addresses everything except: * (48) resizing the mobile splash, which I left as a comment on #580 * (3) add titles like "Today", "Last Week", "..." to Manage Files list which I've filed as #589 (I did reverse the chronological order, however) Attached file has the full list of fixes, along with my notes on implementing them. ScaffoldMessenger GlobalKey change is to fix (2) duplicate "Copied to clipboard" popup.

CWTCH_COLOUR THEMES_FIXES_OCT_2022_erinn_notes.ods

2.1 MiB

sarah was assigned by erinn

2022-12-06 00:27:46 +00:00

erinn added 3 commits 2022-12-06 00:27:46 +00:00

65b0ecc0c3 many theme consistency updates per marcia

007fb02cba another double toast fix, more comment cleanup

continuous-integration/drone/pr Build is pending Details

928a201a3b missing contactsview.dart from last commit

erinn added 1 commit 2022-12-06 00:27:59 +00:00

continuous-integration/drone/pr Build is running Details

91f44d631c Merge branch 'trunk' into 69nicefixes

sarah merged commit 6418170b2e into trunk

2022-12-06 00:33:23 +00:00

sarah referenced this issue from a commit

2022-12-06 00:33:23 +00:00

Merge pull request '69 nice theme fixes' (#590) from 69nicefixes into trunk

buildbot commented

2022-12-06 00:36:40 +00:00

Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/69

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/69

Sign in to join this conversation.

No reviewers

No Label

blocked-on-external

component/bindings

component/connectivity

component/cwtch

component/tapir

cwtch-beta-1.10

cwtch-beta-1.11

cwtch-beta-1.12

cwtch-beta-1.13

cwtch-beta-1.5.x

need-replication-or-investigation

requires-more-effort-than-we-can-spare

waiting-on-fix-confirmation

waiting-on-new-flutter-feature

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#590

No description provided.