font-scaling #672

Merged
sarah merged 5 commits from font-scaling into trunk 3 weeks ago
sarah commented 3 weeks ago
Owner

An initial implementation of font scaling. While I was touching the font code I also took the opportunity to change up our font weights / switch defaults.

An initial implementation of font scaling. While I was touching the font code I also took the opportunity to change up our font weights / switch defaults.
dan was assigned by sarah 3 weeks ago
sarah added 4 commits 3 weeks ago
sarah added 1 commit 3 weeks ago
continuous-integration/drone/pr Build is pending Details
ab5d11b8bb
Update Translation / Text
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/338
dan reviewed 3 weeks ago
textAlign: TextAlign.left,
style: TextStyle(overflow: TextOverflow.ellipsis),
codeStyle: TextStyle(overflow: TextOverflow.ellipsis),
style: TextStyle(fontSize: 12.0 * Provider.of<Settings>(context).fontScaling, fontWeight: FontWeight.normal, fontFamily: "Inter", overflow: TextOverflow.ellipsis),
dan commented 3 weeks ago
Owner

do we want to set a few defined font sizes somewhere in theme so if we ever want to update, we don't have to search and replace a ton of 12s and etc?

do we want to set a few defined font sizes somewhere in theme so if we ever want to update, we don't have to search and replace a ton of 12s and etc?
dan commented 3 weeks ago
Owner

why not use bodySmall or something as defined below? or define this style below?

why not use `bodySmall` or something as defined below? or define this style below?
dan commented 3 weeks ago
Owner

as per chat:
a fast follow is scheduled to dedup dup widgets so that should cut down on this

as per chat: a fast follow is scheduled to dedup dup widgets so that should cut down on this
dan marked this conversation as resolved
titleTextStyle: TextStyle(
color: opaque.current().mainTextColor,
),
titleTextStyle: TextStyle(fontWeight: FontWeight.bold, fontFamily: "Inter", color: opaque.current().mainTextColor, fontSize: opaque.fontScaling * 18.0),
dan commented 3 weeks ago
Owner

yeah here we have title text style with 18 baked in.

but not sure we want all styles in the theme? or do we? prolly not? prolly just moving a few defined sizes in is enough?

yeah here we have title text style with 18 baked in. but not sure we want all styles in the theme? or do we? prolly not? prolly just moving a few defined sizes in is enough?
dan commented 3 weeks ago
Owner

then again, it will make it easier in the future so all new Text fields dont need to manually specify the font as well?

then again, it will make it easier in the future so all new Text fields dont need to manually specify the font as well?
dan commented 3 weeks ago
Owner

oh it's all below, disreguard

oh it's all below, disreguard
dan marked this conversation as resolved
dan approved these changes 3 weeks ago
sarah merged commit 7e74421a3d into trunk 3 weeks ago

Reviewers

dan approved these changes 3 weeks ago
continuous-integration/drone/pr Build is pending
The pull request has been merged as 7e74421a3d.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#672
Loading…
There is no content yet.