An initial implementation of font scaling. While I was touching the font code I also took the opportunity to change up our font weights / switch defaults.
An initial implementation of font scaling. While I was touching the font code I also took the opportunity to change up our font weights / switch defaults.
yeah here we have title text style with 18 baked in.
but not sure we want all styles in the theme? or do we? prolly not? prolly just moving a few defined sizes in is enough?
yeah here we have title text style with 18 baked in.
but not sure we want all styles in the theme? or do we? prolly not? prolly just moving a few defined sizes in is enough?
dan
An initial implementation of font scaling. While I was touching the font code I also took the opportunity to change up our font weights / switch defaults.
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/338
textAlign: TextAlign.left,style: TextStyle(overflow: TextOverflow.ellipsis),codeStyle: TextStyle(overflow: TextOverflow.ellipsis),style: TextStyle(fontSize: 12.0 * Provider.of<Settings>(context).fontScaling, fontWeight: FontWeight.normal, fontFamily: "Inter", overflow: TextOverflow.ellipsis),do we want to set a few defined font sizes somewhere in theme so if we ever want to update, we don't have to search and replace a ton of 12s and etc?
why not use
bodySmallor something as defined below? or define this style below?as per chat:
a fast follow is scheduled to dedup dup widgets so that should cut down on this
titleTextStyle: TextStyle(color: opaque.current().mainTextColor,),titleTextStyle: TextStyle(fontWeight: FontWeight.bold, fontFamily: "Inter", color: opaque.current().mainTextColor, fontSize: opaque.fontScaling * 18.0),yeah here we have title text style with 18 baked in.
but not sure we want all styles in the theme? or do we? prolly not? prolly just moving a few defined sizes in is enough?
then again, it will make it easier in the future so all new Text fields dont need to manually specify the font as well?
oh it's all below, disreguard
7e74421a3dinto trunk 3 weeks agoReviewers
7e74421a3d.