cwtch.im
/
cwtch-ui
10
11
Fork 17
Code Issues 90 Pull Requests 1 Projects 2 Releases 28 Wiki Activity

font-scaling #672

Merged
sarah merged 5 commits from font-scaling into trunk 2023-05-15 22:12:11 +00:00
Conversation 1 Commits 5 Files Changed 66 +703 -218
sarah commented 2023-05-15 19:08:52 +00:00
Owner
Copy Link

An initial implementation of font scaling. While I was touching the font code I also took the opportunity to change up our font weights / switch defaults.

An initial implementation of font scaling. While I was touching the font code I also took the opportunity to change up our font weights / switch defaults.
dan was assigned by sarah 2023-05-15 19:08:52 +00:00
sarah added 4 commits 2023-05-15 19:08:53 +00:00
continuous-integration/drone/pr Build is passing Details
bc677bab05 Update Goldens
sarah added 1 commit 2023-05-15 19:19:02 +00:00
continuous-integration/drone/pr Build is pending Details
ab5d11b8bb Update Translation / Text
buildbot commented 2023-05-15 19:22:06 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/338

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/338
dan reviewed 2023-05-15 19:28:30 +00:00
lib/models/messages/quotedmessage.dart
@ -47,3 +47,2 @@
textAlign: TextAlign.left,
style: TextStyle(overflow: TextOverflow.ellipsis),
codeStyle: TextStyle(overflow: TextOverflow.ellipsis),
style: TextStyle(fontSize: 12.0 * Provider.of<Settings>(context).fontScaling, fontWeight: FontWeight.normal, fontFamily: "Inter", overflow: TextOverflow.ellipsis),
dan commented 2023-05-15 19:15:36 +00:00
Owner
Copy Link

do we want to set a few defined font sizes somewhere in theme so if we ever want to update, we don't have to search and replace a ton of 12s and etc?

do we want to set a few defined font sizes somewhere in theme so if we ever want to update, we don't have to search and replace a ton of 12s and etc?
dan commented 2023-05-15 19:19:08 +00:00
Owner
Copy Link

why not use bodySmall or something as defined below? or define this style below?

why not use `bodySmall` or something as defined below? or define this style below?
dan commented 2023-05-15 21:46:01 +00:00
Owner
Copy Link

as per chat:
a fast follow is scheduled to dedup dup widgets so that should cut down on this

as per chat: a fast follow is scheduled to dedup dup widgets so that should cut down on this
dan marked this conversation as resolved
lib/themes/opaque.dart
@ -157,3 +156,1 @@
titleTextStyle: TextStyle(
color: opaque.current().mainTextColor,
),
titleTextStyle: TextStyle(fontWeight: FontWeight.bold, fontFamily: "Inter", color: opaque.current().mainTextColor, fontSize: opaque.fontScaling * 18.0),
dan commented 2023-05-15 19:17:09 +00:00
Owner
Copy Link

yeah here we have title text style with 18 baked in.

but not sure we want all styles in the theme? or do we? prolly not? prolly just moving a few defined sizes in is enough?

yeah here we have title text style with 18 baked in. but not sure we want all styles in the theme? or do we? prolly not? prolly just moving a few defined sizes in is enough?
dan commented 2023-05-15 19:17:50 +00:00
Owner
Copy Link

then again, it will make it easier in the future so all new Text fields dont need to manually specify the font as well?

then again, it will make it easier in the future so all new Text fields dont need to manually specify the font as well?
dan commented 2023-05-15 19:18:30 +00:00
Owner
Copy Link

oh it's all below, disreguard

oh it's all below, disreguard
dan marked this conversation as resolved
dan approved these changes 2023-05-15 21:46:14 +00:00
sarah merged commit 7e74421a3d into trunk 2023-05-15 22:12:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
android

   
arch

   
backlog

   
blocked-on-external

This issue requires effort from an external organization to move forward

  
bug

Something is not working

  
bugbash

   
component/bindings

   
component/bine

   
component/connectivity

   
component/cwtch

   
component/tapir

   
component/ui

   
cwtch-1.14

   
cwtch-1.15

   
cwtch-beta-1.1

   
cwtch-beta-1.10

Changes Planned for Cwtch Beta 1.10

  
cwtch-beta-1.11

   
cwtch-beta-1.12

   
cwtch-beta-1.13

   
cwtch-beta-1.2

   
cwtch-beta-1.3

   
cwtch-beta-1.4

   
cwtch-beta-1.5

   
cwtch-beta-1.5.x

point release vug fixes for 1.5

  
cwtch-beta-1.6

   
cwtch-beta-1.7

   
cwtch-beta-1.8

   
cwtch-beta-1.9

   
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
flutter

   
funding-needed

   
help wanted

Need some help

  
hybrid-groups

   
in-nightly

   
in-progress

   
invalid

Something is wrong

  
ios

   
linux

   
mac

   
need-replication-or-investigation

   
ops

   
packaging

   
post-stable

These issues won't be considered until after Cwtch Stable ships.

  
question

More information is needed

  
questionable

there is an open question as to whether this is an issue at all / if we can even fix this

  
requires-more-effort-than-we-can-spare

The amount of work involved to solve this issue would occupy our entire development team for a significant period of time and/or provide little benefit to the rest of the project

  
rust

   
scheduled

   
stable-blocker

   
tails

   
testing-needed

   
tests

   
tor

   
waiting-on-fix-confirmation

   
waiting-on-new-flutter-feature

The cause of this issue is a bug in the underlying flutter framework.

  
whonix

   
windows

   
wontfix

This won't be fixed

No Label
android
arch
backlog
blocked-on-external
bug
bugbash
component/bindings
component/bine
component/connectivity
component/cwtch
component/tapir
component/ui
cwtch-1.14
cwtch-1.15
cwtch-beta-1.1
cwtch-beta-1.10
cwtch-beta-1.11
cwtch-beta-1.12
cwtch-beta-1.13
cwtch-beta-1.2
cwtch-beta-1.3
cwtch-beta-1.4
cwtch-beta-1.5
cwtch-beta-1.5.x
cwtch-beta-1.6
cwtch-beta-1.7
cwtch-beta-1.8
cwtch-beta-1.9
design
duplicate
enhancement
flutter
funding-needed
help wanted
hybrid-groups
in-nightly
in-progress
invalid
ios
linux
mac
need-replication-or-investigation
ops
packaging
post-stable
question
questionable
requires-more-effort-than-we-can-spare
rust
scheduled
stable-blocker
tails
testing-needed
tests
tor
waiting-on-fix-confirmation
waiting-on-new-flutter-feature
whonix
windows
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dan
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#672
No description provided.
Delete Branch "font-scaling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?