Reviewers
Request review
No reviewers
Labels
This issue requires effort from an external organization to move forward bug
Something is not working bugbash component/bindings component/bine component/connectivity component/cwtch component/tapir component/ui cwtch-beta-1.1 cwtch-beta-1.10
Changes Planned for Cwtch Beta 1.10 cwtch-beta-1.11 cwtch-beta-1.12 cwtch-beta-1.2 cwtch-beta-1.3 cwtch-beta-1.4 cwtch-beta-1.5 cwtch-beta-1.5.x
point release vug fixes for 1.5 cwtch-beta-1.6 cwtch-beta-1.7 cwtch-beta-1.8 cwtch-beta-1.9 design duplicate
This issue or pull request already exists enhancement
New feature flutter funding-needed help wanted
Need some help in-nightly in-progress invalid
Something is wrong ios linux mac need-replication-or-investigation ops post-stable
These issues won't be considered until after Cwtch Stable ships. question
More information is needed questionable
there is an open question as to whether this is an issue at all / if we can even fix this requires-more-effort-than-we-can-spare
The amount of work involved to solve this issue would occupy our entire development team for a significant period of time and/or provide little benefit to the rest of the project rust scheduled tails testing-needed tor waiting-on-fix-confirmation waiting-on-new-flutter-feature
The cause of this issue is a bug in the underlying flutter framework. whonix windows wontfix
This won't be fixed
Apply labels
Clear labels
android
arch
backlog
blocked-on-external
This issue requires effort from an external organization to move forward bug
Something is not working bugbash component/bindings component/bine component/connectivity component/cwtch component/tapir component/ui cwtch-beta-1.1 cwtch-beta-1.10
Changes Planned for Cwtch Beta 1.10 cwtch-beta-1.11 cwtch-beta-1.12 cwtch-beta-1.2 cwtch-beta-1.3 cwtch-beta-1.4 cwtch-beta-1.5 cwtch-beta-1.5.x
point release vug fixes for 1.5 cwtch-beta-1.6 cwtch-beta-1.7 cwtch-beta-1.8 cwtch-beta-1.9 design duplicate
This issue or pull request already exists enhancement
New feature flutter funding-needed help wanted
Need some help in-nightly in-progress invalid
Something is wrong ios linux mac need-replication-or-investigation ops post-stable
These issues won't be considered until after Cwtch Stable ships. question
More information is needed questionable
there is an open question as to whether this is an issue at all / if we can even fix this requires-more-effort-than-we-can-spare
The amount of work involved to solve this issue would occupy our entire development team for a significant period of time and/or provide little benefit to the rest of the project rust scheduled tails testing-needed tor waiting-on-fix-confirmation waiting-on-new-flutter-feature
The cause of this issue is a bug in the underlying flutter framework. whonix windows wontfix
This won't be fixed
No Label
android
arch
backlog
blocked-on-external
bug
bugbash
component/bindings
component/bine
component/connectivity
component/cwtch
component/tapir
component/ui
cwtch-beta-1.1
cwtch-beta-1.10
cwtch-beta-1.11
cwtch-beta-1.12
cwtch-beta-1.2
cwtch-beta-1.3
cwtch-beta-1.4
cwtch-beta-1.5
cwtch-beta-1.5.x
cwtch-beta-1.6
cwtch-beta-1.7
cwtch-beta-1.8
cwtch-beta-1.9
design
duplicate
enhancement
flutter
funding-needed
help wanted
in-nightly
in-progress
invalid
ios
linux
mac
need-replication-or-investigation
ops
post-stable
question
questionable
requires-more-effort-than-we-can-spare
rust
scheduled
tails
testing-needed
tor
waiting-on-fix-confirmation
waiting-on-new-flutter-feature
whonix
windows
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/cwtch-ui#672
Reference in new issue
There is no content yet.
Delete Branch 'font-scaling'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
An initial implementation of font scaling. While I was touching the font code I also took the opportunity to change up our font weights / switch defaults.
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch-ui/338
textAlign: TextAlign.left,
style: TextStyle(overflow: TextOverflow.ellipsis),
codeStyle: TextStyle(overflow: TextOverflow.ellipsis),
style: TextStyle(fontSize: 12.0 * Provider.of<Settings>(context).fontScaling, fontWeight: FontWeight.normal, fontFamily: "Inter", overflow: TextOverflow.ellipsis),
do we want to set a few defined font sizes somewhere in theme so if we ever want to update, we don't have to search and replace a ton of 12s and etc?
why not use
bodySmall
or something as defined below? or define this style below?as per chat:
a fast follow is scheduled to dedup dup widgets so that should cut down on this
titleTextStyle: TextStyle(
color: opaque.current().mainTextColor,
),
titleTextStyle: TextStyle(fontWeight: FontWeight.bold, fontFamily: "Inter", color: opaque.current().mainTextColor, fontSize: opaque.fontScaling * 18.0),
yeah here we have title text style with 18 baked in.
but not sure we want all styles in the theme? or do we? prolly not? prolly just moving a few defined sizes in is enough?
then again, it will make it easier in the future so all new Text fields dont need to manually specify the font as well?
oh it's all below, disreguard
7e74421a3d
into trunk 3 weeks agoReviewers
7e74421a3d
.