dart-analyzer #822

Closed

sarah wants to merge 2 commits from dart-analyzer into trunk

pull from: dart-analyzer

merge into: cwtch.im:trunk

cwtch.im:trunk

cwtch.im:arm64pt1

cwtch.im:flutter-3.19.3-fixes

cwtch.im:themeFixes2

cwtch.im:lastFixes

cwtch.im:drone-3.19.3

cwtch.im:flutter-3.19.3

cwtch.im:sonoma

cwtch.im:splashFix

cwtch.im:deb

cwtch.im:android_foreground_fix

cwtch.im:android_notif_fix

cwtch.im:fixThemes

cwtch.im:theme-loading-fix

cwtch.im:themeFixes

cwtch.im:themeName

cwtch.im:0.0.12

cwtch.im:fix-images

cwtch.im:streams

cwtch.im:hideblud

cwtch.im:fixchat

cwtch.im:themeBits

cwtch.im:fixGoMobile

cwtch.im:themeImport

cwtch.im:theme

cwtch.im:fixdate

cwtch.im:themeImage

cwtch.im:post-stable-fixes

cwtch.im:settingsPanesFiles

cwtch.im:assetsPath

cwtch.im:i10nupdate

cwtch.im:settingsPanes

cwtch.im:themeImgDir

cwtch.im:pubspecVer

cwtch.im:updateTor

cwtch.im:undoFetchTor

cwtch.im:tor-expert

cwtch.im:mactest

cwtch.im:fixmacdrone

cwtch.im:yamlthemes

cwtch.im:1.13.1

cwtch.im:winemoji

cwtch.im:fixSyncTime

cwtch.im:stable-blockers

cwtch.im:addAutoloadDef

cwtch.im:andro33

cwtch.im:scalingLabel

cwtch.im:search

cwtch.im:repbuilds-additional

cwtch.im:repbuilds

cwtch.im:1.12-rc

cwtch.im:f10lin

cwtch.im:deploy-fixes

cwtch.im:dep-upgrades-3.10.0

cwtch.im:ui-many-fixes

cwtch.im:win-fixes

cwtch.im:macos-3.10

cwtch.im:ui-many

cwtch.im:sw-and-sv

cwtch.im:font-scaling

cwtch.im:detectNetwork

cwtch.im:ui-updates

cwtch.im:tails-fix

cwtch.im:performance

cwtch.im:fixinstsys

cwtch.im:pkg

cwtch.im:status

cwtch.im:tails

cwtch.im:blodeuwedd

cwtch.im:android_export_fix

cwtch.im:savequotes

cwtch.im:autobindings

cwtch.im:testtest

cwtch.im:profile_mgmt

cwtch.im:unicode

cwtch.im:integtest2

cwtch.im:slovak

cwtch.im:flutter3.7.1

cwtch.im:fix-release

cwtch.im:release-builds

cwtch.im:uitests

cwtch.im:fixurls

cwtch.im:scrollbars

cwtch.im:failonfetch

cwtch.im:fixmacbuilds

cwtch.im:fixDeactivate

cwtch.im:noDisable

cwtch.im:glic231

cwtch.im:newjson

cwtch.im:saveAutostart

cwtch.im:serverOfflineIcon

cwtch.im:notiFocus

cwtch.im:formatfixes

cwtch.im:lcgBump

cwtch.im:69nicefixes

cwtch.im:fixes

cwtch.im:fix_linux_install

cwtch.im:lcg1.10

cwtch.im:android_export

cwtch.im:replying_to

cwtch.im:juniper_theme

cwtch.im:smodepriv

cwtch.im:unlockflow

cwtch.im:pt_BR

cwtch.im:cwtchicons

cwtch.im:fix-mac

cwtch.im:update-cwtch

cwtch.im:update-translations

cwtch.im:fixAntispam

cwtch.im:torBump

cwtch.im:qrcode

cwtch.im:antispam

cwtch.im:savedrafts

cwtch.im:load_messages_sync

cwtch.im:noAddContactDup

cwtch.im:debug_access

cwtch.im:locale_tr

cwtch.im:fixquote

cwtch.im:pinned

cwtch.im:winInstructions

cwtch.im:viewreplies

cwtch.im:filesharing-persist

cwtch.im:invite-fix

cwtch.im:android-modal

cwtch.im:ru-update

cwtch.im:androidExported

cwtch.im:1.8.0

cwtch.im:newwincert

cwtch.im:fuzzbot-fixes

cwtch.im:default_message_formatting

cwtch.im:macarm

cwtch.im:intl_fix

cwtch.im:fixFirstSync

cwtch.im:fix_308

cwtch.im:flutter3_notify

cwtch.im:snackbars

cwtch.im:formatting_toolbar_tooltip

cwtch.im:formatting_toolbar

cwtch.im:intl

cwtch.im:marcia_fixes

cwtch.im:show_down

cwtch.im:reply_links

cwtch.im:pl_intl

cwtch.im:fix457

cwtch.im:pubspecBump

cwtch.im:cache3.0

cwtch.im:fix-settings

cwtch.im:replyFix

cwtch.im:file-fixes

cwtch.im:perf

cwtch.im:winUninstall

cwtch.im:cachefixes

cwtch.im:kotlinResult

cwtch.im:linuxNotif

cwtch.im:debuginfo

cwtch.im:androidFlags

cwtch.im:power

cwtch.im:theme-updates

cwtch.im:add_contact_hook

cwtch.im:message-formatting

cwtch.im:mainActivityPort

cwtch.im:unreadSync

cwtch.im:androMessage

cwtch.im:ns

cwtch.im:small_edits

cwtch.im:import_export

cwtch.im:splashExit

cwtch.im:file_bubble_pop_fix

cwtch.im:state

cwtch.im:message_row_fixes

cwtch.im:da

cwtch.im:es

cwtch.im:cy

cwtch.im:messagedate

cwtch.im:i18n

cwtch.im:no

cwtch.im:de

cwtch.im:lb

cwtch.im:ro

cwtch.im:macNotifications

cwtch.im:fix297

cwtch.im:cwtch1.6.1-fixes

cwtch.im:ps160

cwtch.im:lcg160

cwtch.im:droneGherkin

cwtch.im:cwtch_prefix

cwtch.im:maclcg

cwtch.im:notificationSettings

cwtch.im:custom_profile_fixes

cwtch.im:custom_profile_images

cwtch.im:profile_images

cwtch.im:gherkin

cwtch.im:profileNotify

cwtch.im:wintoasts

cwtch.im:fastercwtch

cwtch.im:serverProgress

cwtch.im:winFocus

cwtch.im:winNotify

cwtch.im:androTor

cwtch.im:sender_size

cwtch.im:cache

cwtch.im:torcache

cwtch.im:models

cwtch.im:getinfo

cwtch.im:android-fix

cwtch.im:fix_debug_error_add_contact

cwtch.im:custom_tor_config

cwtch.im:fix_295

cwtch.im:v152

cwtch.im:fixSaveHist

cwtch.im:fixLeave

cwtch.im:fixAndroidAttrInv

cwtch.im:fixAcceptBlock

cwtch.im:appbarColor

cwtch.im:1.5-upgrades

cwtch.im:messageCache

cwtch.im:1.4.0-release

cwtch.im:l10nup

cwtch.im:ios_build_port

cwtch.im:quote

Conversation 3 Commits 2 Files Changed 98 +1611 -1316

sarah commented 2024-02-12 20:51:08 +00:00

Owner

Copy Link

No description provided.

dan was assigned by sarah 2024-02-12 20:51:08 +00:00

sarah added 5 commits 2024-02-12 20:51:09 +00:00

0eb1b95811 Fix Sender Preview for Image Files

88a8ac8cca Fix Height on Invitation Widgets

4ea0d4261c Properly handle image experiment flags when showing sender side images

6ba6f76ee1 Formatting and Consolidate Image Check

c66cc19f22

Dart Analyzer

sarah force-pushed dart-analyzer from c66cc19f22 to 2c853d0106 2024-02-12 21:27:12 +00:00 Compare

sarah added 1 commit 2024-02-12 21:42:20 +00:00

950ee440f3

Add Analysis Options, Ignore Gherkin from dart fix

buildbot commented 2024-02-12 21:54:53 +00:00

Member

Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/656

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/656

sarah force-pushed dart-analyzer from 950ee440f3 to 15b13ad4bf 2024-02-13 04:00:58 +00:00 Compare

dan commented 2024-02-13 04:10:58 +00:00

Owner

Copy Link

that... is a lot of code that was auto"fixed" to review...
running cwtch-ui now with it, so far seems fine

that... is a lot of code that was auto"fixed" to review... running cwtch-ui now with it, so far seems fine

sarah force-pushed dart-analyzer from 15b13ad4bf to 950ee440f3 2024-02-13 18:32:23 +00:00 Compare

dan commented 2024-02-14 01:20:39 +00:00

Owner

Copy Link

has worked for me for a day

has worked for me for a day

dan approved these changes 2024-02-14 01:21:08 +00:00

sarah closed this pull request 2024-02-14 03:20:33 +00:00

Some checks are pending

continuous-integration/drone/pr Build is pending

Required

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

dan

Labels

Clear labels   

android

  

arch

  

backlog

  

blocked-on-external

This issue requires effort from an external organization to move forward

  

bug

Something is not working

  

bugbash

  

component/bindings

  

component/bine

  

component/connectivity

  

component/cwtch

  

component/tapir

  

component/ui

  

cwtch-1.14

  

cwtch-1.15

  

cwtch-beta-1.1

  

cwtch-beta-1.10

Changes Planned for Cwtch Beta 1.10

  

cwtch-beta-1.11

  

cwtch-beta-1.12

  

cwtch-beta-1.13

  

cwtch-beta-1.2

  

cwtch-beta-1.3

  

cwtch-beta-1.4

  

cwtch-beta-1.5

  

cwtch-beta-1.5.x

point release vug fixes for 1.5

  

cwtch-beta-1.6

  

cwtch-beta-1.7

  

cwtch-beta-1.8

  

cwtch-beta-1.9

  

design

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

flutter

  

funding-needed

  

help wanted

Need some help

  

hybrid-groups

  

in-nightly

  

in-progress

  

invalid

Something is wrong

  

ios

  

linux

  

mac

  

need-replication-or-investigation

  

ops

  

packaging

  

post-stable

These issues won't be considered until after Cwtch Stable ships.

  

question

More information is needed

  

questionable

there is an open question as to whether this is an issue at all / if we can even fix this

  

requires-more-effort-than-we-can-spare

The amount of work involved to solve this issue would occupy our entire development team for a significant period of time and/or provide little benefit to the rest of the project

  

rust

  

scheduled

  

stable-blocker

  

tails

  

testing-needed

  

tests

  

tor

  

waiting-on-fix-confirmation

  

waiting-on-new-flutter-feature

The cause of this issue is a bug in the underlying flutter framework.

  

whonix

  

windows

  

wontfix

This won't be fixed

No Label

android

arch

backlog

blocked-on-external

bug

bugbash

component/bindings

component/bine

component/connectivity

component/cwtch

component/tapir

component/ui

cwtch-1.14

cwtch-1.15

cwtch-beta-1.1

cwtch-beta-1.10

cwtch-beta-1.11

cwtch-beta-1.12

cwtch-beta-1.13

cwtch-beta-1.2

cwtch-beta-1.3

cwtch-beta-1.4

cwtch-beta-1.5

cwtch-beta-1.5.x

cwtch-beta-1.6

cwtch-beta-1.7

cwtch-beta-1.8

cwtch-beta-1.9

design

duplicate

enhancement

flutter

funding-needed

help wanted

hybrid-groups

in-nightly

in-progress

invalid

ios

linux

mac

need-replication-or-investigation

ops

packaging

post-stable

question

questionable

requires-more-effort-than-we-can-spare

rust

scheduled

stable-blocker

tails

testing-needed

tests

tor

waiting-on-fix-confirmation

waiting-on-new-flutter-feature

whonix

windows

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

dan

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#822

No description provided.