cwtch.im
/
cwtch-ui
10
11
Fork 17
Code Issues 89 Pull Requests 1 Projects 2 Releases 28 Wiki Activity

Fix Lazy Loading for Themes #827

Merged
sarah merged 2 commits from theme-loading-fix into trunk 2024-02-14 04:06:39 +00:00
Conversation 0 Commits 2 Files Changed 60 +134 -259
sarah commented 2024-02-14 01:01:45 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2024-02-14 01:01:45 +00:00
sarah added 1 commit 2024-02-14 01:01:46 +00:00
dan approved these changes 2024-02-14 02:26:06 +00:00
dan left a comment
Owner
Copy Link

approved pending #829

approved pending #829
lib/themes/opaque.dart Outdated
@ -40,3 +28,1 @@
if (themeId == mode_dark) {
themeId = cwtch_theme;
mode = mode_dark;
LoadThemes(String cwtchDir) async {
dan commented 2024-02-14 01:07:44 +00:00
Owner
Copy Link

we should clear themes or on loading built in themes we should assign those to themes, otherwise successive calls will double up

we should clear themes or on loading built in themes we should assign those to themes, otherwise successive calls will double up
lib/themes/opaque.dart Outdated
@ -41,2 +28,2 @@
themeId = cwtch_theme;
mode = mode_dark;
LoadThemes(String cwtchDir) async {
loadBuiltinThemes().then((dir) {
dan commented 2024-02-14 01:06:46 +00:00
Owner
Copy Link

argument should be called like builtInThemes or something, not dir

argument should be called like `builtInThemes` or something, not `dir`
sarah added 3 commits 2024-02-14 03:17:55 +00:00
sarah changed target branch from 0.0.12 to trunk 2024-02-14 03:21:00 +00:00
sarah force-pushed theme-loading-fix from 726c63c485 to 13a57844af 2024-02-14 03:21:18 +00:00 Compare
sarah force-pushed theme-loading-fix from 13a57844af to f046dd923e 2024-02-14 04:06:02 +00:00 Compare
sarah merged commit 3d2b960a20 into trunk 2024-02-14 04:06:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
android

   
arch

   
backlog

   
blocked-on-external

This issue requires effort from an external organization to move forward

  
bug

Something is not working

  
bugbash

   
component/bindings

   
component/bine

   
component/connectivity

   
component/cwtch

   
component/tapir

   
component/ui

   
cwtch-1.14

   
cwtch-1.15

   
cwtch-beta-1.1

   
cwtch-beta-1.10

Changes Planned for Cwtch Beta 1.10

  
cwtch-beta-1.11

   
cwtch-beta-1.12

   
cwtch-beta-1.13

   
cwtch-beta-1.2

   
cwtch-beta-1.3

   
cwtch-beta-1.4

   
cwtch-beta-1.5

   
cwtch-beta-1.5.x

point release vug fixes for 1.5

  
cwtch-beta-1.6

   
cwtch-beta-1.7

   
cwtch-beta-1.8

   
cwtch-beta-1.9

   
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
flutter

   
funding-needed

   
help wanted

Need some help

  
hybrid-groups

   
in-nightly

   
in-progress

   
invalid

Something is wrong

  
ios

   
linux

   
mac

   
need-replication-or-investigation

   
ops

   
packaging

   
post-stable

These issues won't be considered until after Cwtch Stable ships.

  
question

More information is needed

  
questionable

there is an open question as to whether this is an issue at all / if we can even fix this

  
requires-more-effort-than-we-can-spare

The amount of work involved to solve this issue would occupy our entire development team for a significant period of time and/or provide little benefit to the rest of the project

  
rust

   
scheduled

   
stable-blocker

   
tails

   
testing-needed

   
tests

   
tor

   
waiting-on-fix-confirmation

   
waiting-on-new-flutter-feature

The cause of this issue is a bug in the underlying flutter framework.

  
whonix

   
windows

   
wontfix

This won't be fixed

No Label
android
arch
backlog
blocked-on-external
bug
bugbash
component/bindings
component/bine
component/connectivity
component/cwtch
component/tapir
component/ui
cwtch-1.14
cwtch-1.15
cwtch-beta-1.1
cwtch-beta-1.10
cwtch-beta-1.11
cwtch-beta-1.12
cwtch-beta-1.13
cwtch-beta-1.2
cwtch-beta-1.3
cwtch-beta-1.4
cwtch-beta-1.5
cwtch-beta-1.5.x
cwtch-beta-1.6
cwtch-beta-1.7
cwtch-beta-1.8
cwtch-beta-1.9
design
duplicate
enhancement
flutter
funding-needed
help wanted
hybrid-groups
in-nightly
in-progress
invalid
ios
linux
mac
need-replication-or-investigation
ops
packaging
post-stable
question
questionable
requires-more-effort-than-we-can-spare
rust
scheduled
stable-blocker
tails
testing-needed
tests
tor
waiting-on-fix-confirmation
waiting-on-new-flutter-feature
whonix
windows
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dan
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#827
No description provided.
Delete Branch "theme-loading-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?