cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 1 Releases 163 Wiki Activity

Improve quality.sh
continuous-integration/drone/pr Build was killed Details

This commit is contained in:
Sarah Jamie Lewis 2024-01-02 13:14:06 -08:00
parent 392d709020
commit 3d7ccf4be2
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
testing/quality.sh
View File

@ -4,16 +4,17 @@ echo "Checking code quality (you want to see no output here)"
echo "" echo ""
echo "" echo ""
echo "Linting:" echo "Running staticcheck..."
staticcheck ./... staticcheck ./...
# In the future we should enable this by default. However, there are a few false positives that make this # In the future we should remove include-pkgs. However, there are a few false positives in the overall go stdlib that make this
# too noisy right now, specifically assigning nil to initialize slices (safe), and using go internal context channels assigned # too noisy right now, specifically assigning nil to initialize slices (safe), and using go internal context channels assigned
# nil (also safe). # nil (also safe).
# We also have one file infinite_channel.go written in a way that static analysis cannot reason about easily. So it is explictly # We also have one file infinite_channel.go written in a way that static analysis cannot reason about easily. So it is explictly
# ignored. # ignored.
# nilaway -exclude-file-docstrings="nolint:nilaway" ./... echo "Running nilaway..."
nilaway -include-pkgs="cwtch.im/cwtch,cwtch.im/tapir,git.openprivacy.ca/openprivacy/connectivity" -exclude-file-docstrings="nolint:nilaway" ./...
echo "Time to format" echo "Time to format"
gofmt -l -s -w . gofmt -l -s -w .