cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 1 Releases 163 Wiki Activity

Use a constant-time compare #366

Closed
sarah wants to merge 1 commits from soatok/cwtch:master into master
pull from: soatok/cwtch:master
merge into: cwtch.im:master
Conversation 2 Commits 1 Files Changed 1 +3 -4
sarah commented 2021-06-12 21:46:00 +00:00
Owner
Copy Link
No description provided.
sarah self-assigned this 2021-06-12 21:46:00 +00:00
buildbot commented 2021-06-12 21:46:20 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/203

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/203
sarah reviewed 2021-06-12 21:47:43 +00:00
model/message.go
@ -41,3 +42,1 @@
if a[i] != b[i] {
return false
}
d := d | (a[i] ^ b[i])
sarah commented 2021-06-12 21:47:43 +00:00
Author
Owner
Copy Link

isn't d going to be shadowed here? (should be = instead of := I think)

isn't d going to be shadowed here? (should be `=` instead of `:=` I think)
sarah commented 2021-06-28 23:55:20 +00:00
Author
Owner
Copy Link

This section was clarified in: a3665af870

This section was clarified in: https://git.openprivacy.ca/cwtch.im/cwtch/commit/a3665af87072fe513299e4cfa33cbcd9b0f11699
sarah closed this pull request 2021-06-28 23:55:20 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
sarah
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#366
No description provided.
Delete Branch "soatok/cwtch:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?