cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 1 Releases 163 Wiki Activity

Use a constant-time compare #366

Closed
sarah wants to merge 1 commits from soatok/cwtch:master into master
pull from: soatok/cwtch:master
merge into: cwtch.im:master
Conversation 2 Commits 1 Files Changed 1 +3 -4
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
model/message.go
View File

@ -37,12 +37,11 @@ func compareSignatures(a []byte, b []byte) bool {
if len(a) != len(b) {
return false
}
int d = 0
for i := range a {
if a[i] != b[i] {
return false
}
d := d | (a[i] ^ b[i])
sarah commented 2021-06-12 21:47:43 +00:00
Review
Copy Link

isn't d going to be shadowed here? (should be = instead of := I think)

isn't d going to be shadowed here? (should be `=` instead of `:=` I think)
}
return true
return d == 0
}
// GetMessages returns a copy of the entire timeline