cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

contact retry force disconnect internally any connecting over 2xcircut timeout #521

Merged
sarah merged 1 commits from crForceDisconn into master 2023-07-25 21:22:39 +00:00
Conversation 4 Commits 1 Files Changed 1 +10
dan commented 2023-07-20 04:58:04 +00:00
Owner
Copy Link
No description provided.
sarah reviewed 2023-07-20 20:06:14 +00:00
app/plugins/contactRetry.go Outdated
@ -215,0 +217,4 @@
p := v.(*contact)
if p.state == connections.CONNECTING && time.Now().Sub(p.lastAttempt) > time.Duration(circuitTimeoutSecs)*time.Second*2 {
// we have been "connecting" for twice the circuttimeout so it's failed, we just didn't learn about it, manually disconnect
cr.handleEvent(p.id, connections.DISCONNECTED, p.ctype)
sarah commented 2023-07-20 20:06:14 +00:00
Owner
Copy Link

this needs to log an Error. In normal operation this should not happen, and very likely indicates a failure to handle a missing connection issue somewhere else.

this needs to log an Error. In normal operation this should not happen, and very likely indicates a failure to handle a missing connection issue somewhere else.
dan marked this conversation as resolved
dan force-pushed crForceDisconn from bd2582f8f1 to 7c3e10cdb7 2023-07-21 03:53:27 +00:00 Compare
sarah approved these changes 2023-07-21 04:04:32 +00:00
buildbot commented 2023-07-21 04:06:26 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/196

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/196
decentral1se reviewed 2023-07-21 12:26:07 +00:00
app/plugins/contactRetry.go Outdated
@ -215,0 +218,4 @@
if p.state == connections.CONNECTING && time.Now().Sub(p.lastAttempt) > time.Duration(circuitTimeoutSecs)*time.Second*2 {
// we have been "connecting" for twice the circuttimeout so it's failed, we just didn't learn about it, manually disconnect
cr.handleEvent(p.id, connections.DISCONNECTED, p.ctype)
log.Errorf("had to manually set peer %v of profile %v to DISCONNECTED for connecting for 2xcircutTimeout (%v) seconds", p.id, cr.onion, circuitTimeoutSecs*2)
decentral1se commented 2023-07-21 12:25:44 +00:00
First-time contributor
Copy Link

for connecting for 2xcircutTimeout -> due to a circuit timeout perhaps? circut has a typo also.

`for connecting for 2xcircutTimeout` -> `due to a circuit timeout` perhaps? `circut` has a typo also.
dan marked this conversation as resolved
dan force-pushed crForceDisconn from 7c3e10cdb7 to 33ef2e8b23 2023-07-25 19:57:12 +00:00 Compare
sarah force-pushed crForceDisconn from 33ef2e8b23 to 93b1760c32 2023-07-25 19:58:16 +00:00 Compare
buildbot commented 2023-07-25 19:58:18 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/206

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/206
buildbot commented 2023-07-25 19:59:50 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/207

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/207
dan force-pushed crForceDisconn from 93b1760c32 to fb22efac1f 2023-07-25 20:02:22 +00:00 Compare
buildbot commented 2023-07-25 20:53:16 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/208

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/208
sarah force-pushed crForceDisconn from fb22efac1f to 1f2617e4ae 2023-07-25 21:22:33 +00:00 Compare
sarah merged commit b27229091a into master 2023-07-25 21:22:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sarah
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#521
No description provided.
Delete Branch "crForceDisconn"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?