Clickable hyperlinks for MessageBubbles #235

Addresses #169. Clickable links are added only to MessageBubble, and are locked behind an experiment gate.

Note that the PR is currently riddled with TODOs! Specific questions are annotated directly in the code view here on Git, but the main issues are:

The z-index of the SnackBar is below the modal, and I can't quite figure out how to get it to display above it!
Still need to test on Android emulator
General styling in the modal
onOpen breaks the selectable text

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch-ui/326

@NimaBoscarino This is looking really good :)

I will take a closer look at this early next week and probably get some more comments back to you on Monday. And will also get Marcia to start thinking about the icon for the experiment switch.

I will also make a start at creating the translatable strings.

FYI: When you want to get down to some fuzz testing, I upgraded FuzzBot(4y2hxlxqzautabituedksnh2ulcgm2coqbure6wvfpg4gi2ci25ta5ad) yesterday to be on the most recent version of Cwtch so it should be more available and faster to respond.

Definitely interested to see how blns integrates with this new feature :)

Thanks again!

I tested it out with blns and I didn't catch anything that seemed strange! Just a few things like the pictures attached. Links are only detected if there's an http:// or https:// to start it.

I also managed to set it up to test it out on my Android emulator and it looks like links can open up properly now!

Screen Shot 2021-11-06 at 8.27.25 PM.png

27 KiB

Screen Shot 2021-11-06 at 8.34.10 PM.png

24 KiB

Screen Shot 2021-11-06 at 8.54.47 PM.png

32 KiB

I got this running this morning :) It works very well! And I think this is almost ready to be pulled into nightly.

Few small things:

~~- The color of the links needs to be set. Ideally they should either be set in mkThemeData (referencing .current().mainTextColor() or use Provider.of<Settings>(context).current().mainTextColor()~~

I could not replcicate the issue with text selection on Linux under the most recent Flutter nightly. @dan should probably test this PR on Windows / Mac to see if they can replicate.

Other Notes:

I asked Marcia this morning to work on an Icon. However I would be comfortable merging this into nightly without the Icon being finalized.
Same with translations, I will create the strings today, but I can replace them in a follow up PR.
~~- This change may require an Flutter upgrade to our build server - @dan (url_launcher requires at least 2.4, and we may still be on the earlier dev release`~~

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch-ui/327

@NimaBoscarino - Thank you so much for your work on this. I've been using this experiment for a few days now and it has made a significant improvement to my workflow.

How would you like to credited in the changelog of the next cwtch release? Additionally: is there any profile/website you would like linked to the credit?

@sarah Woo I'm so glad to hear that! And thank you so much for all the help with this issue! You can just credit me as Nima Boscarino, and my site is https://www.n11o.com/

Looks good to me. We've used this to determine we need/are moving our build infra to flutter stable 2.5.3, (from dev 2.5.0-6pre) so I first need to upgrade all the build envs before this can be built and merged

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch-ui/346

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch-ui/340

Merging this. Build bot needs some updates to allow building from different forks. But we've now built this for all platforms.

                 <action android:name="android.intent.action.MAIN"/>
                 <category android:name="android.intent.category.LAUNCHER"/>
             </intent-filter>
             <intent-filter>

                                 },
                                 activeTrackColor: settings.theme.defaultButtonActiveColor(),
                                 inactiveTrackColor: settings.theme.defaultButtonDisabledColor(),
                                 secondary: Icon(Icons.link, color: settings.current().mainTextColor()),

         text: widget.content + '\u202F',
         // TODO: onOpen breaks the "selectable" functionality. Maybe something to do with gesture handler?
         options: LinkifyOptions(humanize: false),
         linkifiers: [UrlLinkifier()],  // TODO: double-check on this (only web links to avoid Android messiness)

     } else {
       wdgMessage = SelectableLinkify(
         text: widget.content + '\u202F',
         // TODO: onOpen breaks the "selectable" functionality. Maybe something to do with gesture handler?

         builder: (BuildContext bcontext) {
           return Container(
               // TODO: Ask re: hard-coded height
               height: 200, // bespoke value courtesy of the [TextField] docs

                           "Opening this link will launch an application outside of Cwtch and may reveal metadata or otherwise compromise the security of Cwtch. Only open links from people you trust. Are you sure you want to continue?"
                         ),
                         // TODO: Ask about styling preferences (should this be a reusable "inline-button"?)
                         Flex(direction: Axis.horizontal, mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[

                                 Clipboard.setData(new ClipboardData(text: link.url));
                                 // TODO: Ask about desired SnackBar + modal behaviour
                                 final snackBar = SnackBar(

                                 secondary: Icon(Icons.attach_file, color: settings.current().mainTextColor()),
                               ),
                               SwitchListTile(
                                 title: Text("Enable Clickable Links", style: TextStyle(color: settings.current().mainTextColor())),

Clickable hyperlinks for MessageBubbles #235

Reviewers