scrolling fixes #244

Merged

erinn merged 4 commits from scrollfixes into trunk

2021-11-11 00:20:02 +00:00

erinn commented

2021-11-11 00:10:53 +00:00

Owner

dual pane: scrolling up in one convo and then going to another now resets scroll position properly (in fact it rebuilds the entire MessageView instead of just swapping out the Provider)
introduces "New Messages" divider line that disappears on the first repaint after 2 minutes
fixes the "scroll to bottom" button not always disappearing (this was a stochastic bug)
fixes initial scroll position when unread messages are present (was: scrolling them just out of sight; now: puts up to 4 into view)

* dual pane: scrolling up in one convo and then going to another now resets scroll position properly (in fact it rebuilds the entire MessageView instead of just swapping out the Provider) * introduces "New Messages" divider line that disappears on the first repaint after 2 minutes * fixes the "scroll to bottom" button not always disappearing (this was a stochastic bug) * fixes initial scroll position when unread messages are present (was: scrolling them just out of sight; now: puts up to 4 into view)

sarah was assigned by erinn

2021-11-11 00:10:53 +00:00

erinn added 3 commits 2021-11-11 00:10:54 +00:00

996cad4ece autoscroll fixes

946d7accb2 Merge branch 'trunk' of git.openprivacy.ca:cwtch.im/cwtch-ui into scrollfixes

continuous-integration/drone/pr Build is passing Details

00ce310cbc l10n update

sarah approved these changes 2021-11-11 00:16:21 +00:00

lib/widgets/messagelist.dart Outdated

					
				@ -72,3 +72,3 @@

				                      itemPositionsListener: widget.scrollListener,

				                      itemScrollController: widget.scrollController,

				                      initialScrollIndex: Provider.of<AppState>(outerContext, listen: false).initialScrollIndex,

				                      initialScrollIndex: initi > 4 ? initi - 4 : 0,//Provider.of<AppState>(outerContext, listen: false).initialScrollIndex - 4,

sarah commented

2021-11-11 00:13:05 +00:00

Owner

delete comment

delete comment

erinn marked this conversation as resolved

buildbot commented

2021-11-11 00:17:36 +00:00

Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/337

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/337

erinn added 1 commit 2021-11-11 00:19:28 +00:00

continuous-integration/drone/pr Build is passing Details

6d261c999b use l10n str

erinn merged commit 6a5309427f into trunk

2021-11-11 00:20:02 +00:00

erinn referenced this issue from a commit

2021-11-11 00:20:02 +00:00

Merge pull request 'scrolling fixes' (#244) from scrollfixes into trunk

buildbot commented

2021-11-17 00:52:25 +00:00

Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch-ui/338

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch-ui/338

Sign in to join this conversation.

No reviewers

No Label

blocked-on-external

component/bindings

component/connectivity

component/cwtch

component/tapir

cwtch-beta-1.10

cwtch-beta-1.11

cwtch-beta-1.12

cwtch-beta-1.13

cwtch-beta-1.5.x

need-replication-or-investigation

requires-more-effort-than-we-can-spare

waiting-on-fix-confirmation

waiting-on-new-flutter-feature

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch-ui#244

No description provided.